Issue 18786005: Cleanup: remove redundant tab close observation from TabModalConfirmDialogDelegate

Issue 18786005: Cleanup: remove redundant tab close observation from TabModalConfirmDialogDelegate (Closed)

Created:
7 years, 5 months ago by Mike Wittman

Modified:
7 years, 5 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, asanka, tim+watch_chromium.org, benjhayden+dwatch_chromium.org, jam, haitaol+watch_chromium.org, stuartmorgan+watch_chromium.org, rsimha+watch_chromium.org, sail, dvh, Elliot Glaysher

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Cleanup: remove redundant tab close observation from TabModalConfirmDialogDelegate The WebContentsModalDialogManager closes web contents modal dialogs when their corresponding WebContents is destroyed. This supersedes the TabModalConfirmDialogDelegate handling of the tab close event. BUG=157161 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212528

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -54 lines)			Patch
M	chrome/browser/download/download_danger_prompt.cc	View		3 chunks	+2 lines, -5 lines	0 comments	Download
M	chrome/browser/plugins/plugin_observer.cc	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/repost_form_warning_controller.cc	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/browser_command_controller_browsertest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm	View	1 2	2 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/tab_modal_confirm_dialog_mac.mm	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/gtk/tab_modal_confirm_dialog_gtk.cc	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/sync/one_click_signin_helper.cc	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/tab_modal_confirm_dialog_browsertest.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc	View		2 chunks	+2 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/tab_modal_confirm_dialog_delegate.h	View	1 2	3 chunks	+2 lines, -12 lines	0 comments	Download
M	chrome/browser/ui/tab_modal_confirm_dialog_delegate.cc	View	1 2	2 chunks	+1 line, -22 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wittman@chromium.org/18786005/14001

7 years, 5 months ago (2013-07-12 17:30:06 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wittman@chromium.org/18786005/18001

7 years, 5 months ago (2013-07-19 00:41:42 UTC) #4

Message was sent while issue was closed.

Change committed as 212528

Expand Messages | Collapse Messages