chrome/browser/ui/gtk/tab_modal_confirm_dialog_gtk.cc - Issue 18786005: Cleanup: remove redundant tab close observation from TabModalConfirmDialogDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/tab_modal_confirm_dialog_gtk.cc

Issue 18786005: Cleanup: remove redundant tab close observation from TabModalConfirmDialogDelegate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/gtk/tab_modal_confirm_dialog_gtk.cc

diff --git a/chrome/browser/ui/gtk/tab_modal_confirm_dialog_gtk.cc b/chrome/browser/ui/gtk/tab_modal_confirm_dialog_gtk.cc

index 625b7c8927a0ea0573e980015639a7f965d666e3..7f419a3b49d59b3d7921a18f4e29db525756bdf4 100644

--- a/chrome/browser/ui/gtk/tab_modal_confirm_dialog_gtk.cc

+++ b/chrome/browser/ui/gtk/tab_modal_confirm_dialog_gtk.cc

@@ -109,6 +109,10 @@ TabModalConfirmDialogGtk::TabModalConfirmDialogGtk(

}

TabModalConfirmDialogGtk::~TabModalConfirmDialogGtk() {

+ // Provide a disposition in case the dialog was closed without accepting or

+ // cancelling.

+ delegate_->Cancel();

gtk_widget_destroy(dialog_);

}

« no previous file with comments | « chrome/browser/ui/cocoa/tab_modal_confirm_dialog_mac.mm ('k') | chrome/browser/ui/sync/one_click_signin_helper.cc » ('j') | no next file with comments »