Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: chrome/browser/download/download_danger_prompt.cc

Issue 18786005: Cleanup: remove redundant tab close observation from TabModalConfirmDialogDelegate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/plugins/plugin_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_danger_prompt.cc
diff --git a/chrome/browser/download/download_danger_prompt.cc b/chrome/browser/download/download_danger_prompt.cc
index bdd75cc4d58c2eb7c6cc8cabcdf19b80154d5bef..d75c6cc040c60b343fb0679b3fa7702b1508492f 100644
--- a/chrome/browser/download/download_danger_prompt.cc
+++ b/chrome/browser/download/download_danger_prompt.cc
@@ -22,7 +22,6 @@ class DownloadDangerPromptImpl
public TabModalConfirmDialogDelegate {
public:
DownloadDangerPromptImpl(content::DownloadItem* item,
- content::WebContents* web_contents,
bool show_context,
const base::Closure& accepted,
const base::Closure& canceled);
@@ -63,12 +62,10 @@ class DownloadDangerPromptImpl
DownloadDangerPromptImpl::DownloadDangerPromptImpl(
content::DownloadItem* download,
- content::WebContents* web_contents,
bool show_context,
const base::Closure& accepted,
const base::Closure& canceled)
- : TabModalConfirmDialogDelegate(web_contents),
- download_(download),
+ : download_(download),
show_context_(show_context),
accepted_(accepted),
canceled_(canceled) {
@@ -175,7 +172,7 @@ DownloadDangerPrompt* DownloadDangerPrompt::Create(
const base::Closure& accepted,
const base::Closure& canceled) {
DownloadDangerPromptImpl* prompt = new DownloadDangerPromptImpl(
- item, web_contents, show_context, accepted, canceled);
+ item, show_context, accepted, canceled);
// |prompt| will be deleted when the dialog is done.
TabModalConfirmDialog::Create(prompt, web_contents);
return prompt;
« no previous file with comments | « no previous file | chrome/browser/plugins/plugin_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698