chrome/browser/ui/sync/one_click_signin_helper.cc - Issue 18786005: Cleanup: remove redundant tab close observation from TabModalConfirmDialogDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/sync/one_click_signin_helper.cc

Issue 18786005: Cleanup: remove redundant tab close observation from TabModalConfirmDialogDelegate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/gtk/tab_modal_confirm_dialog_gtk.cc ('k') | chrome/browser/ui/tab_modal_confirm_dialog_browsertest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/sync/one_click_signin_helper.cc

diff --git a/chrome/browser/ui/sync/one_click_signin_helper.cc b/chrome/browser/ui/sync/one_click_signin_helper.cc

index 484e1df385f17e9474ccafc0aa2d4721bb287c97..a39c0d7be7c15802ba3983ed998f2bb1396eab9e 100644

--- a/chrome/browser/ui/sync/one_click_signin_helper.cc

+++ b/chrome/browser/ui/sync/one_click_signin_helper.cc

@@ -417,8 +417,7 @@ ConfirmEmailDialogDelegate::ConfirmEmailDialogDelegate(

const std::string& last_email,

const std::string& email,

Callback callback)

- : TabModalConfirmDialogDelegate(contents),

- last_email_(last_email),

+ : last_email_(last_email),

email_(email),

callback_(callback) {

}

« no previous file with comments | « chrome/browser/ui/gtk/tab_modal_confirm_dialog_gtk.cc ('k') | chrome/browser/ui/tab_modal_confirm_dialog_browsertest.h » ('j') | no next file with comments »