chrome/browser/ui/browser_command_controller_browsertest.cc - Issue 18786005: Cleanup: remove redundant tab close observation from TabModalConfirmDialogDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_command_controller_browsertest.cc

Issue 18786005: Cleanup: remove redundant tab close observation from TabModalConfirmDialogDelegate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/repost_form_warning_controller.cc ('k') | chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser_command_controller_browsertest.cc

diff --git a/chrome/browser/ui/browser_command_controller_browsertest.cc b/chrome/browser/ui/browser_command_controller_browsertest.cc

index 1f71986976be3a6086a13d3573c2ebd3bcc4eb4a..971014831985a8143a17786550649843edde6741 100644

--- a/chrome/browser/ui/browser_command_controller_browsertest.cc

+++ b/chrome/browser/ui/browser_command_controller_browsertest.cc

@@ -22,7 +22,7 @@ IN_PROC_BROWSER_TEST_F(BrowserCommandControllerBrowserTest, DisableFind) {

content::WebContents* web_contents =

browser()->tab_strip_model()->GetActiveWebContents();

MockTabModalConfirmDialogDelegate* delegate =

- new MockTabModalConfirmDialogDelegate(web_contents, NULL);

+ new MockTabModalConfirmDialogDelegate(NULL);

TabModalConfirmDialog::Create(delegate, web_contents);

EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_FIND));