Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 17388003: Remove unused includes from core/{editing,fileapi,history,html} (Closed)

Created:
7 years, 6 months ago by Timothy Loh
Modified:
7 years, 6 months ago
Reviewers:
pdr.
CC:
blink-reviews, gavinp+prerender_chromium.org, eae+blinkwatch, kinuko, feature-media-reviews_chromium.org, Rik, adamk+blink_chromium.org, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

Remove unused includes from core/{editing,fileapi,history,html} Continue removing unused includes as suggested by include-what-you-use. I've manually looked through the changes here so all the removals should be actually unused. BUG=242216 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152932

Patch Set 1 #

Patch Set 2 : rebased ; update <wtf/Foo.h> to "wtf/Foo.h" in changed files #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -400 lines) Patch
M Source/core/editing/CompositeEditCommand.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/DeleteSelectionCommand.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/editing/EditCommand.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/editing/EditingStyle.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/Editor.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/Editor.cpp View 1 4 chunks +1 line, -13 lines 0 comments Download
M Source/core/editing/FrameSelection.cpp View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/editing/HTMLInterchange.cpp View 1 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/editing/IndentOutdentCommand.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/InsertListCommand.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/InsertTextCommand.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/SpellChecker.h View 1 1 chunk +5 lines, -6 lines 0 comments Download
M Source/core/editing/VisibleUnits.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/markup.cpp View 2 chunks +0 lines, -9 lines 0 comments Download
M Source/core/fileapi/Blob.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/fileapi/BlobBuilder.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/fileapi/File.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/history/HistoryItem.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/history/HistoryItem.cpp View 1 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/html/BaseDateAndTimeInputType.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/BaseDateAndTimeInputType.cpp View 1 1 chunk +4 lines, -5 lines 0 comments Download
M Source/core/html/ClassList.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/html/ClassList.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/ColorInputType.cpp View 1 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/html/DOMFormData.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/DOMSettableTokenList.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/html/DOMURL.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/DateInputType.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/DateTimeFieldsState.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/DateTimeLocalInputType.cpp View 1 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/html/FormController.h View 1 1 chunk +4 lines, -5 lines 0 comments Download
M Source/core/html/HTMLCanvasElement.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLCollection.h View 1 1 chunk +3 lines, -5 lines 0 comments Download
M Source/core/html/HTMLCollection.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLDocument.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/html/HTMLEmbedElement.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/html/HTMLFieldSetElement.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 1 chunk +0 lines, -11 lines 0 comments Download
M Source/core/html/HTMLFrameOwnerElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLIFrameElement.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLImportsController.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 2 chunks +1 line, -4 lines 0 comments Download
M Source/core/html/HTMLLegendElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLLinkElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLLinkElement.cpp View 1 3 chunks +1 line, -2 lines 0 comments Download
M Source/core/html/HTMLMarqueeElement.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 4 chunks +8 lines, -14 lines 0 comments Download
M Source/core/html/HTMLMeterElement.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLOptionElement.cpp View 1 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/html/HTMLOutputElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLPlugInElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLPlugInImageElement.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/html/HTMLPlugInImageElement.cpp View 1 1 chunk +0 lines, -15 lines 0 comments Download
M Source/core/html/HTMLProgressElement.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLSourceElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLTableElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTitleElement.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/html/HTMLTrackElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLVideoElement.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/ImageInputType.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/InputType.h View 1 1 chunk +4 lines, -5 lines 0 comments Download
M Source/core/html/LinkResource.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/MediaController.h View 1 1 chunk +3 lines, -5 lines 0 comments Download
M Source/core/html/MediaFragmentURIParser.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/NumberInputType.cpp View 1 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/html/PublicURLManager.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/RadioNodeList.h View 1 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/html/StepRange.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/html/TextFieldInputType.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/TypeAhead.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/html/ValidationMessage.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/ValidityState.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/html/canvas/CanvasPathMethods.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext.h View 1 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 1 2 chunks +5 lines, -15 lines 0 comments Download
M Source/core/html/canvas/OESVertexArrayObject.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLBuffer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLBuffer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/canvas/WebGLCompressedTextureATC.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/canvas/WebGLCompressedTextureS3TC.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/canvas/WebGLCompressedTextureS3TC.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/html/canvas/WebGLContextObject.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/canvas/WebGLDebugShaders.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLObject.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLProgram.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/canvas/WebGLRenderbuffer.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/canvas/WebGLRenderingContext.h View 1 1 chunk +4 lines, -5 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContext.cpp View 1 1 chunk +4 lines, -5 lines 0 comments Download
M Source/core/html/canvas/WebGLShader.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/canvas/WebGLTexture.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/html/canvas/WebGLUniformLocation.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/canvas/WebGLVertexArrayObjectOES.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/html/parser/BackgroundHTMLParser.h View 1 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/html/parser/BackgroundHTMLParser.cpp View 1 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/html/parser/CSSPreloadScanner.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/parser/HTMLConstructionSite.h View 1 1 chunk +4 lines, -5 lines 0 comments Download
M Source/core/html/parser/HTMLConstructionSite.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/html/parser/HTMLDocumentParser.h View 1 1 chunk +4 lines, -5 lines 0 comments Download
M Source/core/html/parser/HTMLDocumentParser.cpp View 1 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/html/parser/HTMLElementStack.h View 1 1 chunk +5 lines, -6 lines 0 comments Download
M Source/core/html/parser/HTMLParserIdioms.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/html/parser/HTMLParserIdioms.cpp View 1 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/html/parser/HTMLParserScheduler.h View 1 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/html/parser/HTMLPreloadScanner.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/html/parser/HTMLSourceTracker.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/parser/HTMLTokenizer.cpp View 1 1 chunk +3 lines, -6 lines 0 comments Download
M Source/core/html/parser/HTMLTreeBuilder.h View 1 1 chunk +7 lines, -8 lines 0 comments Download
M Source/core/html/parser/HTMLTreeBuilder.cpp View 1 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/html/parser/HTMLTreeBuilderSimulator.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/html/parser/XSSAuditor.cpp View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/html/parser/XSSAuditorDelegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/shadow/DateTimeEditElement.cpp View 1 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/html/shadow/HTMLContentElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/shadow/HTMLContentElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/shadow/HTMLShadowElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/shadow/MediaControlElements.cpp View 1 2 chunks +0 lines, -8 lines 0 comments Download
M Source/core/html/shadow/MediaControls.h View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/core/html/shadow/PickerIndicatorElement.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/shadow/SliderThumbElement.h View 1 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/html/shadow/SliderThumbElement.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/shadow/TextControlInnerElements.cpp View 1 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/html/track/InbandTextTrack.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/html/track/LoadableTextTrack.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/html/track/LoadableTextTrack.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/track/TextTrack.h View 1 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/html/track/TextTrackCue.h View 1 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/html/track/TextTrackCue.cpp View 1 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/html/track/TextTrackCueGeneric.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/track/TextTrackList.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Timothy Loh
7 years, 6 months ago (2013-06-20 09:07:12 UTC) #1
pdr.
On 2013/06/20 09:07:12, Timothy Loh wrote: LGTM, really nice work as always. (Apologies for the ...
7 years, 6 months ago (2013-06-22 17:08:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/17388003/49001
7 years, 6 months ago (2013-06-23 06:29:15 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-23 07:58:23 UTC) #4
Message was sent while issue was closed. 
Change committed as 152932

Powered by Google App Engine
This is Rietveld 408576698