Consolidate/clarify TabLaunchTypes

Consolidate/clarify TabLaunchTypes

A bunch of these don't incur specific behavior, are not being
used, or aren't even being used properly.

* FROM_CHROME_UI replaces FROM_MENU_OR_OVERVIEW and FROM_KEYBOARD,
  and is overloaded to account for tabs created by other Chrome
  UI, like Push Notifications.

* FROM_KEYBOARD was being used by tests when creating new tabs when
  FROM_MENU_OR_OVERVIEW worked fine.  It was removed entirely
  because nothing was actually checking it specifically: it was
  even grouped in with FROM_MENU_OR_OVERVIEW in switch statements.

* FROM_INSTANT wasn't being set anywhere, but was being checked in
  two places.  I straight deleted it.

BUG=582539
Committed: https://crrev.com/63d6410809958054a570c783680a3a175eafa624
Cr-Commit-Position: refs/heads/master@{#376342}

[gone, 2016-02-18 21:20:33]

dfalcantara@chromium.org changed reviewers:
+ newt@chromium.org

[gone, 2016-02-18 21:26:56]

Description was changed from

==========
Consolidate/clarify TabLaunchTypes

A bunch of these don't incur specific behavior, are not being used, or aren't
even being used properly.

BUG=582539

[Herb] General Dill fixes

* Dill opens regular CCTs on top of the original app if they don't request
  NEW_TASK/NEW_DOCUMENT.

* Dill doesn't close migrated tabs when you hit back.

BUG=582539
==========

to

==========
Consolidate/clarify TabLaunchTypes

A bunch of these don't incur specific behavior, are not being used, or aren't
even being used properly.

BUG=582539
==========

[newt (away), 2016-02-18 22:05:18]

It'd be helpful to mention which launch types you've removed in the commit
message.

Otherwise lgtm!

[gone, 2016-02-18 23:18:55]

Description was changed from

==========
Consolidate/clarify TabLaunchTypes

A bunch of these don't incur specific behavior, are not being used, or aren't
even being used properly.

BUG=582539
==========

to

==========
Consolidate/clarify TabLaunchTypes

A bunch of these don't incur specific behavior, are not being 
used, or aren't even being used properly.

Specifically, the new FROM_CHROME_UI replaces FROM_MENU_OR_OVERVIEW and
FROM_KEYBOARD, and is overloaded to account for tabs created by other Chrome UI,
like Push Notifications.

FROM_INSTANT wasn't being set anywhere, but was being checked in two places.

BUG=582539
==========

[gone, 2016-02-18 23:22:30]

Description was changed from

==========
Consolidate/clarify TabLaunchTypes

A bunch of these don't incur specific behavior, are not being 
used, or aren't even being used properly.

Specifically, the new FROM_CHROME_UI replaces FROM_MENU_OR_OVERVIEW and
FROM_KEYBOARD, and is overloaded to account for tabs created by other Chrome UI,
like Push Notifications.

FROM_INSTANT wasn't being set anywhere, but was being checked in two places.

BUG=582539
==========

to

==========
Consolidate/clarify TabLaunchTypes

A bunch of these don't incur specific behavior, are not being 
used, or aren't even being used properly.

* FROM_CHROME_UI replaces FROM_MENU_OR_OVERVIEW and FROM_KEYBOARD,
  and is overloaded to account for tabs created by other Chrome
  UI, like Push Notifications.

* FROM_KEYBOARD was being used by tests when creating new tabs when
  FROM_MENU_OR_OVERVIEW worked fine.  It was removed entirely
  because nothing was actually checking it specifically: it was
  even grouped in with FROM_MENU_OR_OVERVIEW in switch statements.

* FROM_INSTANT wasn't being set anywhere, but was being checked in
  two places.  I straight deleted it.

BUG=582539
==========

[gone, 2016-02-19 00:57:03]

Updated the message; thanks!

[gone, 2016-02-19 00:59:11]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2016-02-19 00:59:11]

The patchset sent to the CQ was uploaded after l-g-t-m from newt@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1710213002/#ps30001
(title: "Rebasing")

[commit-bot: I haz the power, 2016-02-19 01:05:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1710213002/30001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1710213002/30001

[commit-bot: I haz the power, 2016-02-19 01:56:39]

Description was changed from

==========
Consolidate/clarify TabLaunchTypes

A bunch of these don't incur specific behavior, are not being 
used, or aren't even being used properly.

* FROM_CHROME_UI replaces FROM_MENU_OR_OVERVIEW and FROM_KEYBOARD,
  and is overloaded to account for tabs created by other Chrome
  UI, like Push Notifications.

* FROM_KEYBOARD was being used by tests when creating new tabs when
  FROM_MENU_OR_OVERVIEW worked fine.  It was removed entirely
  because nothing was actually checking it specifically: it was
  even grouped in with FROM_MENU_OR_OVERVIEW in switch statements.

* FROM_INSTANT wasn't being set anywhere, but was being checked in
  two places.  I straight deleted it.

BUG=582539
==========

to

==========
Consolidate/clarify TabLaunchTypes

A bunch of these don't incur specific behavior, are not being 
used, or aren't even being used properly.

* FROM_CHROME_UI replaces FROM_MENU_OR_OVERVIEW and FROM_KEYBOARD,
  and is overloaded to account for tabs created by other Chrome
  UI, like Push Notifications.

* FROM_KEYBOARD was being used by tests when creating new tabs when
  FROM_MENU_OR_OVERVIEW worked fine.  It was removed entirely
  because nothing was actually checking it specifically: it was
  even grouped in with FROM_MENU_OR_OVERVIEW in switch statements.

* FROM_INSTANT wasn't being set anywhere, but was being checked in
  two places.  I straight deleted it.

BUG=582539
==========

[commit-bot: I haz the power, 2016-02-19 01:56:40]

Committed patchset #3 (id:30001)

[commit-bot: I haz the power, 2016-02-19 01:57:39]

Description was changed from

==========
Consolidate/clarify TabLaunchTypes

A bunch of these don't incur specific behavior, are not being 
used, or aren't even being used properly.

* FROM_CHROME_UI replaces FROM_MENU_OR_OVERVIEW and FROM_KEYBOARD,
  and is overloaded to account for tabs created by other Chrome
  UI, like Push Notifications.

* FROM_KEYBOARD was being used by tests when creating new tabs when
  FROM_MENU_OR_OVERVIEW worked fine.  It was removed entirely
  because nothing was actually checking it specifically: it was
  even grouped in with FROM_MENU_OR_OVERVIEW in switch statements.

* FROM_INSTANT wasn't being set anywhere, but was being checked in
  two places.  I straight deleted it.

BUG=582539
==========

to

==========
Consolidate/clarify TabLaunchTypes

A bunch of these don't incur specific behavior, are not being
used, or aren't even being used properly.

* FROM_CHROME_UI replaces FROM_MENU_OR_OVERVIEW and FROM_KEYBOARD,
  and is overloaded to account for tabs created by other Chrome
  UI, like Push Notifications.

* FROM_KEYBOARD was being used by tests when creating new tabs when
  FROM_MENU_OR_OVERVIEW worked fine.  It was removed entirely
  because nothing was actually checking it specifically: it was
  even grouped in with FROM_MENU_OR_OVERVIEW in switch statements.

* FROM_INSTANT wasn't being set anywhere, but was being checked in
  two places.  I straight deleted it.

BUG=582539

Committed: https://crrev.com/63d6410809958054a570c783680a3a175eafa624
Cr-Commit-Position: refs/heads/master@{#376342}
==========

[commit-bot: I haz the power, 2016-02-19 01:57:40]

Patchset 3 (id:??) landed as
https://crrev.com/63d6410809958054a570c783680a3a175eafa624
Cr-Commit-Position: refs/heads/master@{#376342}