chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java - Issue 1710213002: Consolidate/clarify TabLaunchTypes

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java

Issue 1710213002: Consolidate/clarify TabLaunchTypes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebasing Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/ChromeActivityTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java

index 718c8edad07ab4429c553ce53b6dff813747679d..484464cffa9bd3cb3c4564d24c18c49d0e2fedf4 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java

@@ -192,7 +192,7 @@ public class BindingManagerIntegrationTest extends ChromeActivityTestCaseBase<Ch

TabCreator tabCreator = getActivity().getCurrentTabCreator();

tabs[0] = tabCreator.createNewTab(

new LoadUrlParams(mTestServer.getURL(FILE_PATH)),

- TabLaunchType.FROM_KEYBOARD, null);

+ TabLaunchType.FROM_CHROME_UI, null);

// Background tab.

tabs[1] = tabCreator.createNewTab(

new LoadUrlParams(mTestServer.getURL(FILE_PATH)),

@@ -263,7 +263,7 @@ public class BindingManagerIntegrationTest extends ChromeActivityTestCaseBase<Ch

TabCreator tabCreator = getActivity().getCurrentTabCreator();

tabs[0] = tabCreator.createNewTab(

new LoadUrlParams(mTestServer.getURL(FILE_PATH)),

- TabLaunchType.FROM_KEYBOARD, null);

+ TabLaunchType.FROM_CHROME_UI, null);

// Background tab.

tabs[1] = tabCreator.createNewTab(

new LoadUrlParams(mTestServer.getURL(FILE_PATH)),

@@ -368,7 +368,7 @@ public class BindingManagerIntegrationTest extends ChromeActivityTestCaseBase<Ch

TabCreator tabCreator = getActivity().getCurrentTabCreator();

return tabCreator.createNewTab(

new LoadUrlParams(mTestServer.getURL(FILE_PATH)),

- TabLaunchType.FROM_KEYBOARD, null);

+ TabLaunchType.FROM_CHROME_UI, null);

}

});

ChromeTabUtils.waitForTabPageLoaded(tab, mTestServer.getURL(FILE_PATH));

@@ -442,7 +442,7 @@ public class BindingManagerIntegrationTest extends ChromeActivityTestCaseBase<Ch

TabCreator tabCreator = getActivity().getCurrentTabCreator();

return tabCreator.createNewTab(

new LoadUrlParams(mTestServer.getURL(FILE_PATH)),

- TabLaunchType.FROM_KEYBOARD, null);

+ TabLaunchType.FROM_CHROME_UI, null);

}});

ChromeTabUtils.waitForTabPageLoaded(fgTab, mTestServer.getURL(FILE_PATH));

int initialNavigationPid = getRenderProcessId(fgTab);

@@ -504,10 +504,10 @@ public class BindingManagerIntegrationTest extends ChromeActivityTestCaseBase<Ch

public void run() {

// Foreground tab.

tabs[0] = tabCreator.createNewTab(

- new LoadUrlParams("about:blank"), TabLaunchType.FROM_KEYBOARD, null);

+ new LoadUrlParams("about:blank"), TabLaunchType.FROM_CHROME_UI, null);

// Background tab.

tabs[1] = tabCreator.createNewTab(

- new LoadUrlParams("about:blank"), TabLaunchType.FROM_KEYBOARD, null);

+ new LoadUrlParams("about:blank"), TabLaunchType.FROM_CHROME_UI, null);

}

});

ChromeTabUtils.waitForTabPageLoaded(tabs[0], "about:blank");

@@ -520,7 +520,7 @@ public class BindingManagerIntegrationTest extends ChromeActivityTestCaseBase<Ch

public void run() {

// Foreground tab.

tabs[2] = tabCreator.createNewTab(

- new LoadUrlParams("about:blank"), TabLaunchType.FROM_KEYBOARD, null);

+ new LoadUrlParams("about:blank"), TabLaunchType.FROM_CHROME_UI, null);

}

});

ChromeTabUtils.waitForTabPageLoaded(tabs[2], "about:blank");