chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelJniBridge.java - Issue 1710213002: Consolidate/clarify TabLaunchTypes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelJniBridge.java

Issue 1710213002: Consolidate/clarify TabLaunchTypes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebasing Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModel.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelJniBridge.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelJniBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelJniBridge.java

index e341ead27e932eb3356be19c018415aef17b3b1c..d6a0a51ddd8e44946930a77198d9a0b7bd4b65f1 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelJniBridge.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelJniBridge.java

@@ -123,7 +123,7 @@ public abstract class TabModelJniBridge implements TabModel {

@CalledByNative

protected Tab createNewTabForDevTools(String url) {

return getTabCreator(false).createNewTab(new LoadUrlParams(url),

- TabModel.TabLaunchType.FROM_MENU_OR_OVERVIEW, null);

+ TabModel.TabLaunchType.FROM_CHROME_UI, null);

}

@Override