chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java - Issue 1710213002: Consolidate/clarify TabLaunchTypes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java

Issue 1710213002: Consolidate/clarify TabLaunchTypes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebasing Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java

index bcc1c4478ee580497c512c9c7cb042e3d0d18263..91bd08beb9c520ac4fcb0a6d81277aa4b4d6b4cd 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java

@@ -781,7 +781,7 @@ public class DocumentActivity extends ChromeActivity {

if (hasTabState) return TabLaunchType.FROM_RESTORE;

if (isAffiliated) return TabLaunchType.FROM_LONGPRESS_BACKGROUND;

if (!TextUtils.isEmpty(url) && url.equals(UrlConstants.NTP_URL)) {

- return TabLaunchType.FROM_MENU_OR_OVERVIEW;

+ return TabLaunchType.FROM_CHROME_UI;

}

return TabLaunchType.FROM_EXTERNAL_APP;

}

@@ -792,7 +792,7 @@ public class DocumentActivity extends ChromeActivity {

new AsyncTabCreationParams(new LoadUrlParams(searchUrl, PageTransition.LINK));

asyncParams.setDocumentStartedBy(DocumentMetricIds.STARTED_BY_CONTEXTUAL_SEARCH);

getTabCreator(false).createNewTab(

- asyncParams, TabLaunchType.FROM_MENU_OR_OVERVIEW, getActivityTab().getId());

+ asyncParams, TabLaunchType.FROM_CHROME_UI, getActivityTab().getId());

}

@Override