chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java - Issue 1710213002: Consolidate/clarify TabLaunchTypes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java

Issue 1710213002: Consolidate/clarify TabLaunchTypes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebasing Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelJniBridge.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java

index c095092e886f2e4b7002e60fc3dd90c9064aeb36..ff8ccad95b35c9451f5874d483ef4541cc1e02fc 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java

@@ -116,7 +116,7 @@ public class TabDelegate extends TabCreator {

} else if (type == TabLaunchType.FROM_LONGPRESS_BACKGROUND

|| type == TabLaunchType.FROM_LONGPRESS_FOREGROUND) {

asyncParams.setDocumentStartedBy(DocumentMetricIds.STARTED_BY_CONTEXT_MENU);

- } else if (type == TabLaunchType.FROM_MENU_OR_OVERVIEW) {

+ } else if (type == TabLaunchType.FROM_CHROME_UI) {

asyncParams.setDocumentStartedBy(DocumentMetricIds.STARTED_BY_OPTIONS_MENU);

}