|
|
Make all tests use GetActiveDesktop() instead of hardcoding HOST_DESKTOP_TYPE_NATIVE.
Also adds checks to in_process_browser_test.cc to ensure browsers that are still alive at the end of a test are all on the active desktop (i.e. on the Ash desktop in the case of Ash browser_tests on Windows).
BUG= 179830
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+69 lines, -73 lines) |
Patch |
 |
M |
chrome/browser/app_controller_mac_browsertest.mm
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/chrome_browser_main.cc
|
View
|
|
1 chunk |
+2 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/api/test/test_api.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/extension_context_menu_model_unittest.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/managed_mode/managed_mode_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/performance_monitor/performance_monitor_browsertest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/policy/policy_browsertest.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/printing/print_preview_dialog_controller.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/profiles/avatar_menu_model_browsertest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/profiles/profile_manager_unittest.cc
|
View
|
|
5 chunks |
+6 lines, -12 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/test/integration/sync_test.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/browser_browsertest.cc
|
View
|
|
2 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/browser_command_controller_unittest.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/browser_navigator_browsertest.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller_unittest.mm
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
|
View
|
|
4 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/cocoa_profile_test.mm
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/notifications/balloon_controller_unittest.mm
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/profile_menu_controller_unittest.mm
|
View
|
|
2 chunks |
+2 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
|
chrome/browser/ui/search/instant_extended_interactive_uitest.cc
|
View
|
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
|
chrome/test/base/in_process_browser_test.cc
|
View
|
|
7 chunks |
+24 lines, -10 lines |
0 comments
|
Download
|
|
M |
chrome/test/base/ui_test_utils.cc
|
View
|
|
1 chunk |
+3 lines, -4 lines |
0 comments
|
Download
|
|
Chromium Code Reviews
Issue
16174003:
Make all tests use GetActiveDesktop() instead of hardcoding HOST_DESKTOP_TYPE_NATIVE. (Closed)
