chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm - Issue 16174003: Make all tests use GetActiveDesktop() instead of hardcoding HOST_DESKTOP_TYPE_NATIVE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm

Issue 16174003: Make all tests use GetActiveDesktop() instead of hardcoding HOST_DESKTOP_TYPE_NATIVE. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/cocoa_profile_test.mm ('k') | chrome/browser/ui/cocoa/notifications/balloon_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm

diff --git a/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm b/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm

index 2c61e803c0b74ab48463a75e50458ac6bcf1bfc8..8d81d0aea057d973d6343e010634d3fc337a7e7e 100644

--- a/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm

+++ b/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm

@@ -123,7 +123,7 @@ IN_PROC_BROWSER_TEST_F(DevToolsControllerTest, WebViewLayout) {

// Verify that the dev tools undocked window is layed out correctly.

IN_PROC_BROWSER_TEST_F(DevToolsControllerTest, UndockedOffset) {

BrowserList* browser_list =

- BrowserList::GetInstance(chrome::HOST_DESKTOP_TYPE_NATIVE);

+ BrowserList::GetInstance(chrome::GetActiveDesktop());

EXPECT_EQ(1u, browser_list->size());

SetDockSide(DEVTOOLS_DOCK_SIDE_UNDOCKED);

EXPECT_EQ(2u, browser_list->size());