chrome/browser/ui/cocoa/profile_menu_controller_unittest.mm - Issue 16174003: Make all tests use GetActiveDesktop() instead of hardcoding HOST_DESKTOP_TYPE_NATIVE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/profile_menu_controller_unittest.mm

Issue 16174003: Make all tests use GetActiveDesktop() instead of hardcoding HOST_DESKTOP_TYPE_NATIVE. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/notifications/balloon_controller_unittest.mm ('k') | chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/profile_menu_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/profile_menu_controller_unittest.mm b/chrome/browser/ui/cocoa/profile_menu_controller_unittest.mm

index 06f22b395eb295a87f8b823639c6621f4574815b..3518864cda7944039a6e3471cb974668651adfe6 100644

--- a/chrome/browser/ui/cocoa/profile_menu_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/profile_menu_controller_unittest.mm

@@ -197,8 +197,7 @@ TEST_F(ProfileMenuControllerTest, SetActiveAndRemove) {

ASSERT_EQ(7, [menu numberOfItems]);

// Create a browser and "show" it.

- Browser::CreateParams profile2_params(profile2,

- chrome::HOST_DESKTOP_TYPE_NATIVE);

+ Browser::CreateParams profile2_params(profile2, chrome::GetActiveDesktop());

scoped_ptr<Browser> p2_browser(

chrome::CreateBrowserWithTestWindowForParams(&profile2_params));

BrowserList::SetLastActive(p2_browser.get());

@@ -209,8 +208,7 @@ TEST_F(ProfileMenuControllerTest, SetActiveAndRemove) {

VerifyProfileNamedIsActive(@"Profile 2", __LINE__);

// Open a new browser and make sure it takes effect.

- Browser::CreateParams profile3_params(profile3,

- chrome::HOST_DESKTOP_TYPE_NATIVE);

+ Browser::CreateParams profile3_params(profile3, chrome::GetActiveDesktop());

scoped_ptr<Browser> p3_browser(

chrome::CreateBrowserWithTestWindowForParams(&profile3_params));

BrowserList::SetLastActive(p3_browser.get());