chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc - Issue 16174003: Make all tests use GetActiveDesktop() instead of hardcoding HOST_DESKTOP_TYPE_NATIVE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc

Issue 16174003: Make all tests use GetActiveDesktop() instead of hardcoding HOST_DESKTOP_TYPE_NATIVE. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/search/instant_extended_interactive_uitest.cc ('k') | chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc

diff --git a/chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc b/chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc

index dee248b23d762758893dd2d2b0c330eafd537f62..e60137d99453e44f5d1451ecf575c08f83660674 100644

--- a/chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc

+++ b/chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc

@@ -499,8 +499,7 @@ TEST_F(BackFwdMenuModelTest, EscapeLabel) {

TEST_F(BackFwdMenuModelTest, FaviconLoadTest) {

profile()->CreateHistoryService(true, false);

profile()->CreateFaviconService();

- Browser::CreateParams native_params(profile(),

- chrome::HOST_DESKTOP_TYPE_NATIVE);

+ Browser::CreateParams native_params(profile(), chrome::GetActiveDesktop());

scoped_ptr<Browser> browser(

chrome::CreateBrowserWithTestWindowForParams(&native_params));

FaviconDelegate favicon_delegate;