chrome/browser/ui/browser_navigator_browsertest.cc - Issue 16174003: Make all tests use GetActiveDesktop() instead of hardcoding HOST_DESKTOP_TYPE_NATIVE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_navigator_browsertest.cc

Issue 16174003: Make all tests use GetActiveDesktop() instead of hardcoding HOST_DESKTOP_TYPE_NATIVE. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/browser_command_controller_unittest.cc ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser_navigator_browsertest.cc

diff --git a/chrome/browser/ui/browser_navigator_browsertest.cc b/chrome/browser/ui/browser_navigator_browsertest.cc

index 5baf2858b0f70023b1291371fb5f8499a591d155..8cd9080b0c5da8a88a1d5d37ec3fc02c28c5d354 100644

--- a/chrome/browser/ui/browser_navigator_browsertest.cc

+++ b/chrome/browser/ui/browser_navigator_browsertest.cc

@@ -79,7 +79,7 @@ chrome::NavigateParams BrowserNavigatorTest::MakeNavigateParams(

Browser* BrowserNavigatorTest::CreateEmptyBrowserForType(Browser::Type type,

Profile* profile) {

Browser* browser = new Browser(

- Browser::CreateParams(type, profile, chrome::HOST_DESKTOP_TYPE_NATIVE));

+ Browser::CreateParams(type, profile, chrome::GetActiveDesktop()));

chrome::AddBlankTabAt(browser, -1, true);

return browser;

}

@@ -89,7 +89,7 @@ Browser* BrowserNavigatorTest::CreateEmptyBrowserForApp(Browser::Type type,

Browser* browser = new Browser(

Browser::CreateParams::CreateForApp(

Browser::TYPE_POPUP, "Test", gfx::Rect(), profile,

- chrome::HOST_DESKTOP_TYPE_NATIVE));

+ chrome::GetActiveDesktop()));

chrome::AddBlankTabAt(browser, -1, true);

return browser;

}