chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm - Issue 16174003: Make all tests use GetActiveDesktop() instead of hardcoding HOST_DESKTOP_TYPE_NATIVE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm

Issue 16174003: Make all tests use GetActiveDesktop() instead of hardcoding HOST_DESKTOP_TYPE_NATIVE. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller_unittest.mm ('k') | chrome/browser/ui/cocoa/browser_window_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm b/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm

index adb1817441a0b6ecb7080f42fbf42f41839e22be..26f686316bc6e6ee00e4488fd6dd852e212f2691 100644

--- a/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm

+++ b/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm

@@ -574,7 +574,7 @@ IN_PROC_BROWSER_TEST_F(BrowserWindowControllerTest, SheetPosition) {

chrome::OpenAppShortcutWindow(

browser()->profile(), GURL("about:blank"), initial_bounds);

Browser* popup_browser = BrowserList::GetInstance(

- chrome::HOST_DESKTOP_TYPE_NATIVE)->GetLastActive();

+ chrome::GetActiveDesktop())->GetLastActive();

NSWindow* popupWindow = popup_browser->window()->GetNativeWindow();

BrowserWindowController* popupController =

[BrowserWindowController browserWindowControllerForWindow:popupWindow];