Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 14876034: Enable Clang warnings for implementation files on all platforms. (Closed)

Created:
7 years, 7 months ago by Ryan Sleevi
Modified:
7 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, browser-components-watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, android-webview-reviews_chromium.org, justincohen
Visibility:
Public.

Description

Enable Clang warnings for implementation files on all platforms. This fixes a few remaining issues for Android builds BUG=115047 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200125

Patch Set 1 #

Patch Set 2 : gypi style tweak #

Messages

Total messages: 7 (0 generated)
Ryan Sleevi
darin: Hopefully the last of the rubberstamps. This turns the warning on everywhere (eg: including ...
7 years, 7 months ago (2013-05-13 22:48:08 UTC) #1
mkosiba (inactive)
android_webview LGTM
7 years, 7 months ago (2013-05-14 09:40:59 UTC) #2
darin (slow to review)
LGTM
7 years, 7 months ago (2013-05-14 21:00:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/14876034/10002
7 years, 7 months ago (2013-05-14 21:02:41 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 7 months ago (2013-05-14 21:17:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/14876034/10002
7 years, 7 months ago (2013-05-14 21:29:44 UTC) #6
commit-bot: I haz the power
7 years, 7 months ago (2013-05-15 00:45:09 UTC) #7
Message was sent while issue was closed.
Change committed as 200125

Powered by Google App Engine
This is Rietveld 408576698