Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Side by Side Diff: chrome/browser/history/android/android_provider_backend_unittest.cc

Issue 14876034: Enable Clang warnings for implementation files on all platforms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: gypi style tweak Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/history/android/android_provider_backend.h" 5 #include "chrome/browser/history/android/android_provider_backend.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/file_util.h" 9 #include "base/file_util.h"
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 107
108 class AndroidProviderBackendTest : public testing::Test { 108 class AndroidProviderBackendTest : public testing::Test {
109 public: 109 public:
110 AndroidProviderBackendTest() 110 AndroidProviderBackendTest()
111 : profile_manager_( 111 : profile_manager_(
112 TestingBrowserProcess::GetGlobal()), 112 TestingBrowserProcess::GetGlobal()),
113 bookmark_model_(NULL), 113 bookmark_model_(NULL),
114 ui_thread_(BrowserThread::UI, &message_loop_), 114 ui_thread_(BrowserThread::UI, &message_loop_),
115 file_thread_(BrowserThread::FILE, &message_loop_) { 115 file_thread_(BrowserThread::FILE, &message_loop_) {
116 } 116 }
117 ~AndroidProviderBackendTest() { 117 virtual ~AndroidProviderBackendTest() {}
118 }
119 118
120 protected: 119 protected:
121 virtual void SetUp() OVERRIDE { 120 virtual void SetUp() OVERRIDE {
122 // Setup the testing profile, so the bookmark_model_sql_handler could 121 // Setup the testing profile, so the bookmark_model_sql_handler could
123 // get the bookmark model from it. 122 // get the bookmark model from it.
124 ASSERT_TRUE(profile_manager_.SetUp()); 123 ASSERT_TRUE(profile_manager_.SetUp());
125 // It seems that the name has to be chrome::kInitialProfile, so it 124 // It seems that the name has to be chrome::kInitialProfile, so it
126 // could be found by ProfileManager::GetLastUsedProfile(). 125 // could be found by ProfileManager::GetLastUsedProfile().
127 TestingProfile* testing_profile = profile_manager_.CreateTestingProfile( 126 TestingProfile* testing_profile = profile_manager_.CreateTestingProfile(
128 chrome::kInitialProfile); 127 chrome::kInitialProfile);
(...skipping 1942 matching lines...) Expand 10 before | Expand all | Expand 10 after
2071 update_args, &update_count)); 2070 update_args, &update_count));
2072 // Verify notifications. 2071 // Verify notifications.
2073 EXPECT_FALSE(delegate_.deleted_details()); 2072 EXPECT_FALSE(delegate_.deleted_details());
2074 ASSERT_TRUE(delegate_.modified_details()); 2073 ASSERT_TRUE(delegate_.modified_details());
2075 ASSERT_EQ(1u, delegate_.modified_details()->changed_urls.size()); 2074 ASSERT_EQ(1u, delegate_.modified_details()->changed_urls.size());
2076 // No favicon will be updated as thumbnail database is missing. 2075 // No favicon will be updated as thumbnail database is missing.
2077 EXPECT_FALSE(delegate_.favicon_details()); 2076 EXPECT_FALSE(delegate_.favicon_details());
2078 } 2077 }
2079 2078
2080 } // namespace history 2079 } // namespace history
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698