Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(855)

Side by Side Diff: chrome/browser/history/android/urls_sql_handler_unittest.cc

Issue 14876034: Enable Clang warnings for implementation files on all platforms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: gypi style tweak Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <vector> 5 #include <vector>
6 6
7 #include "chrome/browser/history/android/urls_sql_handler.h" 7 #include "chrome/browser/history/android/urls_sql_handler.h"
8 8
9 #include "base/file_util.h" 9 #include "base/file_util.h"
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
11 #include "base/files/scoped_temp_dir.h" 11 #include "base/files/scoped_temp_dir.h"
12 #include "base/stringprintf.h" 12 #include "base/stringprintf.h"
13 #include "base/utf_string_conversions.h" 13 #include "base/utf_string_conversions.h"
14 #include "chrome/browser/history/android/visit_sql_handler.h" 14 #include "chrome/browser/history/android/visit_sql_handler.h"
15 #include "chrome/browser/history/history_database.h" 15 #include "chrome/browser/history/history_database.h"
16 #include "chrome/common/chrome_constants.h" 16 #include "chrome/common/chrome_constants.h"
17 #include "testing/gtest/include/gtest/gtest.h" 17 #include "testing/gtest/include/gtest/gtest.h"
18 18
19 using base::Time; 19 using base::Time;
20 using base::TimeDelta; 20 using base::TimeDelta;
21 21
22 namespace history { 22 namespace history {
23 23
24 class UrlsSQLHandlerTest : public testing::Test { 24 class UrlsSQLHandlerTest : public testing::Test {
25 public: 25 public:
26 UrlsSQLHandlerTest() 26 UrlsSQLHandlerTest()
27 : urls_sql_handler_(&history_db_), 27 : urls_sql_handler_(&history_db_),
28 visit_sql_handler_(&history_db_) { 28 visit_sql_handler_(&history_db_) {
29 } 29 }
30 ~UrlsSQLHandlerTest() { 30 virtual ~UrlsSQLHandlerTest() {}
31 }
32 31
33 protected: 32 protected:
34 virtual void SetUp() { 33 virtual void SetUp() {
35 // Get a temporary directory for the test DB files. 34 // Get a temporary directory for the test DB files.
36 ASSERT_TRUE(temp_dir_.CreateUniqueTempDir()); 35 ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
37 base::FilePath history_db_name = temp_dir_.path().AppendASCII( 36 base::FilePath history_db_name = temp_dir_.path().AppendASCII(
38 chrome::kHistoryFilename); 37 chrome::kHistoryFilename);
39 ASSERT_EQ(sql::INIT_OK, history_db_.Init(history_db_name, NULL)); 38 ASSERT_EQ(sql::INIT_OK, history_db_.Init(history_db_name, NULL));
40 } 39 }
41 40
(...skipping 294 matching lines...) Expand 10 before | Expand all | Expand 10 after
336 335
337 TableIDRow id; 336 TableIDRow id;
338 id.url_id = url_row.id(); 337 id.url_id = url_row.id();
339 TableIDRows ids; 338 TableIDRows ids;
340 ids.push_back(id); 339 ids.push_back(id);
341 ASSERT_TRUE(urls_sql_handler_.Delete(ids)); 340 ASSERT_TRUE(urls_sql_handler_.Delete(ids));
342 EXPECT_FALSE(history_db_.GetURLRow(row.url_id(), &url_row)); 341 EXPECT_FALSE(history_db_.GetURLRow(row.url_id(), &url_row));
343 } 342 }
344 343
345 } // namespace history 344 } // namespace history
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698