Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc

Issue 14876034: Enable Clang warnings for implementation files on all platforms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: gypi style tweak Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/native/aw_contents_io_thread_client_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc
diff --git a/android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc b/android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc
index 0e83a40b8b8a16b9b80fc88902f250a78a8dca9e..33e826c1feda4be83503d0b7ed8f4efa13cc959e 100644
--- a/android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc
+++ b/android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc
@@ -47,15 +47,15 @@ class NotImplInputStream : public InputStream {
public:
NotImplInputStream() {}
virtual ~NotImplInputStream() {}
- virtual bool BytesAvailable(int* bytes_available) const {
+ virtual bool BytesAvailable(int* bytes_available) const OVERRIDE {
NOTIMPLEMENTED();
return false;
}
- virtual bool Skip(int64_t n, int64_t* bytes_skipped) {
+ virtual bool Skip(int64_t n, int64_t* bytes_skipped) OVERRIDE {
NOTIMPLEMENTED();
return false;
}
- virtual bool Read(net::IOBuffer* dest, int length, int* bytes_read) {
+ virtual bool Read(net::IOBuffer* dest, int length, int* bytes_read) OVERRIDE {
NOTIMPLEMENTED();
return false;
}
@@ -69,28 +69,26 @@ class StreamReaderDelegate :
virtual scoped_ptr<InputStream> OpenInputStream(
JNIEnv* env,
- const GURL& url) {
+ const GURL& url) OVERRIDE {
return make_scoped_ptr<InputStream>(new NotImplInputStream());
}
virtual void OnInputStreamOpenFailed(net::URLRequest* request,
- bool* restart) {
+ bool* restart) OVERRIDE {
*restart = false;
}
- virtual bool GetMimeType(
- JNIEnv* env,
- net::URLRequest* request,
- android_webview::InputStream* stream,
- std::string* mime_type) {
+ virtual bool GetMimeType(JNIEnv* env,
+ net::URLRequest* request,
+ android_webview::InputStream* stream,
+ std::string* mime_type) OVERRIDE {
return false;
}
- virtual bool GetCharset(
- JNIEnv* env,
- net::URLRequest* request,
- android_webview::InputStream* stream,
- std::string* charset) {
+ virtual bool GetCharset(JNIEnv* env,
+ net::URLRequest* request,
+ android_webview::InputStream* stream,
+ std::string* charset) OVERRIDE {
return false;
}
};
@@ -101,7 +99,7 @@ class NullStreamReaderDelegate : public StreamReaderDelegate {
virtual scoped_ptr<InputStream> OpenInputStream(
JNIEnv* env,
- const GURL& url) {
+ const GURL& url) OVERRIDE {
return make_scoped_ptr<InputStream>(NULL);
}
};
@@ -131,13 +129,13 @@ class TestStreamReaderJob : public AndroidStreamReaderURLRequestJob {
}
virtual scoped_ptr<InputStreamReader> CreateStreamReader(
- InputStream* stream) {
+ InputStream* stream) OVERRIDE {
return stream_reader_.Pass();
}
protected:
virtual ~TestStreamReaderJob() {}
- virtual base::TaskRunner* GetWorkerThreadRunner() {
+ virtual base::TaskRunner* GetWorkerThreadRunner() OVERRIDE {
return message_loop_proxy_.get();
}
« no previous file with comments | « no previous file | android_webview/native/aw_contents_io_thread_client_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698