Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Side by Side Diff: chrome/browser/history/android/bookmark_model_sql_handler_unittest.cc

Issue 14876034: Enable Clang warnings for implementation files on all platforms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: gypi style tweak Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/history/android/bookmark_model_sql_handler.h" 5 #include "chrome/browser/history/android/bookmark_model_sql_handler.h"
6 6
7 #include "base/synchronization/waitable_event.h" 7 #include "base/synchronization/waitable_event.h"
8 #include "base/utf_string_conversions.h" 8 #include "base/utf_string_conversions.h"
9 #include "chrome/browser/bookmarks/bookmark_model.h" 9 #include "chrome/browser/bookmarks/bookmark_model.h"
10 #include "chrome/browser/bookmarks/bookmark_model_factory.h" 10 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
(...skipping 14 matching lines...) Expand all
25 25
26 class BookmarkModelSQLHandlerTest : public testing::Test { 26 class BookmarkModelSQLHandlerTest : public testing::Test {
27 public: 27 public:
28 BookmarkModelSQLHandlerTest() 28 BookmarkModelSQLHandlerTest()
29 : profile_manager_( 29 : profile_manager_(
30 TestingBrowserProcess::GetGlobal()), 30 TestingBrowserProcess::GetGlobal()),
31 bookmark_model_(NULL), 31 bookmark_model_(NULL),
32 ui_thread_(BrowserThread::UI, &message_loop_), 32 ui_thread_(BrowserThread::UI, &message_loop_),
33 file_thread_(BrowserThread::FILE, &message_loop_) { 33 file_thread_(BrowserThread::FILE, &message_loop_) {
34 } 34 }
35 ~BookmarkModelSQLHandlerTest() { 35 virtual ~BookmarkModelSQLHandlerTest() {}
36 }
37 36
38 protected: 37 protected:
39 virtual void SetUp() OVERRIDE { 38 virtual void SetUp() OVERRIDE {
40 // Setup the testing profile, so the bookmark_model_sql_handler could 39 // Setup the testing profile, so the bookmark_model_sql_handler could
41 // get the bookmark model from it. 40 // get the bookmark model from it.
42 ASSERT_TRUE(profile_manager_.SetUp()); 41 ASSERT_TRUE(profile_manager_.SetUp());
43 // It seems that the name has to be chrome::kInitialProfile, so it 42 // It seems that the name has to be chrome::kInitialProfile, so it
44 // could be found by ProfileManager::GetLastUsedProfile(). 43 // could be found by ProfileManager::GetLastUsedProfile().
45 TestingProfile* testing_profile = profile_manager_.CreateTestingProfile( 44 TestingProfile* testing_profile = profile_manager_.CreateTestingProfile(
46 chrome::kInitialProfile); 45 chrome::kInitialProfile);
(...skipping 197 matching lines...) Expand 10 before | Expand all | Expand 10 after
244 id_row.url = url1; 243 id_row.url = url1;
245 id_rows.clear(); 244 id_rows.clear();
246 id_rows.push_back(id_row); 245 id_rows.push_back(id_row);
247 ASSERT_TRUE(handler.Delete(id_rows)); 246 ASSERT_TRUE(handler.Delete(id_rows));
248 RunMessageLoopForUI(); 247 RunMessageLoopForUI();
249 // All bookmarks were deleted. 248 // All bookmarks were deleted.
250 EXPECT_FALSE(bookmark_model_->HasBookmarks()); 249 EXPECT_FALSE(bookmark_model_->HasBookmarks());
251 } 250 }
252 251
253 } // namespace history 252 } // namespace history
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698