android_webview/native/aw_contents_io_thread_client_impl.cc - Issue 14876034: Enable Clang warnings for implementation files on all platforms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_contents_io_thread_client_impl.cc

Issue 14876034: Enable Clang warnings for implementation files on all platforms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: gypi style tweak Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/native/aw_contents_io_thread_client_impl.cc

diff --git a/android_webview/native/aw_contents_io_thread_client_impl.cc b/android_webview/native/aw_contents_io_thread_client_impl.cc

index de8f1b1a9da3cab0732bb4de17a673effd6a261a..226ba551141e4d213aa5921d2e9ca05aab9bfdaa 100644

--- a/android_webview/native/aw_contents_io_thread_client_impl.cc

+++ b/android_webview/native/aw_contents_io_thread_client_impl.cc

@@ -104,7 +104,7 @@ class ClientMapEntryUpdater : public content::WebContentsObserver {

virtual void RenderViewForInterstitialPageCreated(

RenderViewHost* render_view_host) OVERRIDE;

virtual void RenderViewDeleted(RenderViewHost* render_view_host) OVERRIDE;

- virtual void WebContentsDestroyed(WebContents* web_contents);

+ virtual void WebContentsDestroyed(WebContents* web_contents) OVERRIDE;

private:

JavaObjectWeakGlobalRef jdelegate_;