Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14241002: Move the parsing of app.launch related keys out of Extension class. (Closed)

Created:
7 years, 8 months ago by JoeThomas
Modified:
7 years, 1 month ago
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, dbeam+watch-options_chromium.org, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, jeremya+watch_chromium.org, sail+watch_chromium.org, Aaron Boodman, oshima+watch_chromium.org, estade+watch_chromium.org, chromium-apps-reviews_chromium.org, James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, pedrosimonetti+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move the parsing of app.launch related keys out of Extension class. BUG=159265 TBR=ben@chromium.org

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+636 lines, -322 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/autocomplete/extension_app_provider.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/screensaver/screensaver_controller.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/management/management_api.cc View 2 chunks +2 lines, -1 line 0 comments Download
A chrome/browser/extensions/app_launch_manifest_parser.h View 1 chunk +36 lines, -0 lines 0 comments Download
A chrome/browser/extensions/app_launch_manifest_parser.cc View 1 chunk +28 lines, -0 lines 0 comments Download
M chrome/browser/extensions/convert_web_app_browsertest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/convert_web_app_unittest.cc View 4 chunks +5 lines, -2 lines 1 comment Download
M chrome/browser/extensions/extension_prefs.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.cc View 2 chunks +3 lines, -1 line 1 comment Download
M chrome/browser/extensions/extension_service_unittest.cc View 8 chunks +17 lines, -9 lines 0 comments Download
M chrome/browser/extensions/tab_helper.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_dependency_manager.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/extensions/application_launch.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/tabs/pinned_tab_codec.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_unittest.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/ui/web_applications/web_app_ui.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_icon_source.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/content_settings_handler.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/web_applications/web_app.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/common/extensions/app_launcher_info.h View 1 chunk +78 lines, -0 lines 3 comments Download
A chrome/common/extensions/app_launcher_info.cc View 1 chunk +325 lines, -0 lines 1 comment Download
M chrome/common/extensions/extension.h View 5 chunks +4 lines, -35 lines 0 comments Download
M chrome/common/extensions/extension.cc View 7 chunks +5 lines, -216 lines 0 comments Download
M chrome/common/extensions/extension_manifest_constants.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/extension_manifest_constants.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_launch_unittest.cc View 4 chunks +29 lines, -16 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc View 1 chunk +16 lines, -6 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_web_unittest.cc View 2 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
JoeThomas
This CL is moved from https://chromiumcodereview.appspot.com/12316077/ as there is a change of email address.
7 years, 8 months ago (2013-04-13 04:50:51 UTC) #1
Devlin
https://chromiumcodereview.appspot.com/14241002/diff/1/chrome/browser/extensions/convert_web_app_unittest.cc File chrome/browser/extensions/convert_web_app_unittest.cc (right): https://chromiumcodereview.appspot.com/14241002/diff/1/chrome/browser/extensions/convert_web_app_unittest.cc#newcode23 chrome/browser/extensions/convert_web_app_unittest.cc:23: #include "chrome/common/extensions/manifest_handler.h" I don't think you need the generic ...
7 years, 8 months ago (2013-04-16 21:40:58 UTC) #2
Yoyo Zhou
7 years, 8 months ago (2013-04-16 23:18:24 UTC) #3 
https://chromiumcodereview.appspot.com/14241002/diff/1/chrome/common/extensio...
File chrome/common/extensions/app_launcher_info.h (right):

https://chromiumcodereview.appspot.com/14241002/diff/1/chrome/common/extensio...
chrome/common/extensions/app_launcher_info.h:20: class AppLauncherInfo : public
Extension::ManifestData {
This should be AppLaunchInfo.

Powered by Google App Engine
This is Rietveld 408576698