Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Side by Side Diff: chrome/browser/extensions/extension_prefs.cc

Issue 14241002: Move the parsing of app.launch related keys out of Extension class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_prefs.h" 5 #include "chrome/browser/extensions/extension_prefs.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/prefs/pref_notifier.h" 8 #include "base/prefs/pref_notifier.h"
9 #include "base/prefs/pref_service.h" 9 #include "base/prefs/pref_service.h"
10 #include "base/string_util.h" 10 #include "base/string_util.h"
11 #include "base/strings/string_number_conversions.h" 11 #include "base/strings/string_number_conversions.h"
12 #include "base/utf_string_conversions.h" 12 #include "base/utf_string_conversions.h"
13 #include "base/version.h" 13 #include "base/version.h"
14 #include "chrome/browser/extensions/admin_policy.h" 14 #include "chrome/browser/extensions/admin_policy.h"
15 #include "chrome/browser/extensions/api/file_handlers/app_file_handler_util.h" 15 #include "chrome/browser/extensions/api/file_handlers/app_file_handler_util.h"
16 #include "chrome/browser/extensions/api/omnibox/omnibox_api.h" 16 #include "chrome/browser/extensions/api/omnibox/omnibox_api.h"
17 #include "chrome/browser/extensions/extension_pref_store.h" 17 #include "chrome/browser/extensions/extension_pref_store.h"
18 #include "chrome/browser/extensions/extension_sorting.h" 18 #include "chrome/browser/extensions/extension_sorting.h"
19 #include "chrome/browser/prefs/scoped_user_pref_update.h" 19 #include "chrome/browser/prefs/scoped_user_pref_update.h"
20 #include "chrome/browser/ui/host_desktop.h" 20 #include "chrome/browser/ui/host_desktop.h"
21 #include "chrome/common/chrome_notification_types.h" 21 #include "chrome/common/chrome_notification_types.h"
22 #include "chrome/common/chrome_switches.h" 22 #include "chrome/common/chrome_switches.h"
23 #include "chrome/common/chrome_version_info.h" 23 #include "chrome/common/chrome_version_info.h"
24 #include "chrome/common/extensions/app_launcher_info.h"
24 #include "chrome/common/extensions/feature_switch.h" 25 #include "chrome/common/extensions/feature_switch.h"
25 #include "chrome/common/extensions/manifest.h" 26 #include "chrome/common/extensions/manifest.h"
26 #include "chrome/common/extensions/permissions/permission_set.h" 27 #include "chrome/common/extensions/permissions/permission_set.h"
27 #include "chrome/common/extensions/permissions/permissions_info.h" 28 #include "chrome/common/extensions/permissions/permissions_info.h"
28 #include "chrome/common/pref_names.h" 29 #include "chrome/common/pref_names.h"
29 #include "chrome/common/url_constants.h" 30 #include "chrome/common/url_constants.h"
30 #include "components/user_prefs/pref_registry_syncable.h" 31 #include "components/user_prefs/pref_registry_syncable.h"
31 #include "content/public/browser/notification_service.h" 32 #include "content/public/browser/notification_service.h"
32 #include "extensions/common/url_pattern.h" 33 #include "extensions/common/url_pattern.h"
33 #include "grit/generated_resources.h" 34 #include "grit/generated_resources.h"
(...skipping 1183 matching lines...) Expand 10 before | Expand all | Expand 10 after
1217 result = LAUNCH_REGULAR; 1218 result = LAUNCH_REGULAR;
1218 #endif // OS_WIN 1219 #endif // OS_WIN
1219 1220
1220 return result; 1221 return result;
1221 } 1222 }
1222 1223
1223 extension_misc::LaunchContainer ExtensionPrefs::GetLaunchContainer( 1224 extension_misc::LaunchContainer ExtensionPrefs::GetLaunchContainer(
1224 const Extension* extension, 1225 const Extension* extension,
1225 ExtensionPrefs::LaunchType default_pref_value) { 1226 ExtensionPrefs::LaunchType default_pref_value) {
1226 extension_misc::LaunchContainer manifest_launch_container = 1227 extension_misc::LaunchContainer manifest_launch_container =
1227 extension->launch_container(); 1228 AppLauncherInfo::GetLaunchContainer(extension);
1228 1229
1229 const extension_misc::LaunchContainer kInvalidLaunchContainer = 1230 const extension_misc::LaunchContainer kInvalidLaunchContainer =
1230 static_cast<extension_misc::LaunchContainer>(-1); 1231 static_cast<extension_misc::LaunchContainer>(-1);
1231 1232
1232 extension_misc::LaunchContainer result = kInvalidLaunchContainer; 1233 extension_misc::LaunchContainer result = kInvalidLaunchContainer;
1233 1234
1234 if (manifest_launch_container == extension_misc::LAUNCH_PANEL) { 1235 if (manifest_launch_container == extension_misc::LAUNCH_PANEL) {
1235 // Apps with app.launch.container = 'panel' should always respect the 1236 // Apps with app.launch.container = 'panel' should always respect the
1236 // manifest setting. 1237 // manifest setting.
1237 result = manifest_launch_container; 1238 result = manifest_launch_container;
(...skipping 1122 matching lines...) Expand 10 before | Expand all | Expand 10 after
2360 is_enabled = initial_state == Extension::ENABLED; 2361 is_enabled = initial_state == Extension::ENABLED;
2361 } 2362 }
2362 2363
2363 extension_pref_value_map_->RegisterExtension(extension_id, install_time, 2364 extension_pref_value_map_->RegisterExtension(extension_id, install_time,
2364 is_enabled); 2365 is_enabled);
2365 content_settings_store_->RegisterExtension(extension_id, install_time, 2366 content_settings_store_->RegisterExtension(extension_id, install_time,
2366 is_enabled); 2367 is_enabled);
2367 } 2368 }
2368 2369
2369 } // namespace extensions 2370 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698