chrome/browser/extensions/extension_service.cc - Issue 14241002: Move the parsing of app.launch related keys out of Extension class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 14241002: Move the parsing of app.launch related keys out of Extension class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/convert_web_app_unittest.cc ('K') | « chrome/browser/extensions/extension_prefs.cc ('k') | chrome/browser/extensions/extension_service_unittest.cc » ('j') | chrome/common/extensions/app_launcher_info.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_service.cc

diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc

index 15b6e1e08b8e3cff9a9d43151b99d4b1234e8d13..533dea917e5f4a3bd4f917b5933c4bdaa0377181 100644

--- a/chrome/browser/extensions/extension_service.cc

+++ b/chrome/browser/extensions/extension_service.cc

@@ -78,6 +78,7 @@

#include "chrome/common/chrome_switches.h"

#include "chrome/common/chrome_version_info.h"

#include "chrome/common/extensions/api/plugins/plugins_handler.h"

+#include "chrome/common/extensions/app_launcher_info.h"

#include "chrome/common/extensions/background_info.h"

#include "chrome/common/extensions/extension.h"

#include "chrome/common/extensions/extension_file_util.h"

@@ -845,7 +846,8 @@ bool ExtensionService::UninstallExtension(

NOTREACHED();

}

- GURL launch_web_url_origin(extension->launch_web_url());

+ GURL launch_web_url_origin(

+ extensions::AppLauncherInfo::GetLaunchWebURL(extension));

launch_web_url_origin = launch_web_url_origin.GetOrigin();

Devlin 2013/04/16 21:40:58 nit: why not just do GURL launch_web_url_origin(

bool is_storage_isolated =

extensions::AppIsolationInfo::HasIsolatedStorage(extension);