Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Side by Side Diff: chrome/browser/ui/tabs/pinned_tab_codec.cc

Issue 14241002: Move the parsing of app.launch related keys out of Extension class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/tabs/pinned_tab_codec.h" 5 #include "chrome/browser/ui/tabs/pinned_tab_codec.h"
6 6
7 #include "base/prefs/pref_service.h" 7 #include "base/prefs/pref_service.h"
8 #include "base/values.h" 8 #include "base/values.h"
9 #include "chrome/browser/extensions/tab_helper.h" 9 #include "chrome/browser/extensions/tab_helper.h"
10 #include "chrome/browser/prefs/scoped_user_pref_update.h" 10 #include "chrome/browser/prefs/scoped_user_pref_update.h"
11 #include "chrome/browser/profiles/profile.h" 11 #include "chrome/browser/profiles/profile.h"
12 #include "chrome/browser/ui/browser.h" 12 #include "chrome/browser/ui/browser.h"
13 #include "chrome/browser/ui/browser_iterator.h" 13 #include "chrome/browser/ui/browser_iterator.h"
14 #include "chrome/browser/ui/browser_list.h" 14 #include "chrome/browser/ui/browser_list.h"
15 #include "chrome/browser/ui/tabs/tab_strip_model.h" 15 #include "chrome/browser/ui/tabs/tab_strip_model.h"
16 #include "chrome/common/extensions/app_launcher_info.h"
16 #include "chrome/common/extensions/extension.h" 17 #include "chrome/common/extensions/extension.h"
17 #include "chrome/common/pref_names.h" 18 #include "chrome/common/pref_names.h"
18 #include "components/user_prefs/pref_registry_syncable.h" 19 #include "components/user_prefs/pref_registry_syncable.h"
19 #include "content/public/browser/navigation_entry.h" 20 #include "content/public/browser/navigation_entry.h"
20 #include "content/public/browser/web_contents.h" 21 #include "content/public/browser/web_contents.h"
21 22
22 using content::NavigationEntry; 23 using content::NavigationEntry;
23 24
24 // Key used in dictionaries for the app id. 25 // Key used in dictionaries for the app id.
25 static const char kAppID[] = "app_id"; 26 static const char kAppID[] = "app_id";
(...skipping 29 matching lines...) Expand all
55 56
56 content::WebContents* web_contents = model->GetWebContentsAt(index); 57 content::WebContents* web_contents = model->GetWebContentsAt(index);
57 if (model->IsAppTab(index)) { 58 if (model->IsAppTab(index)) {
58 const extensions::Extension* extension = 59 const extensions::Extension* extension =
59 extensions::TabHelper::FromWebContents(web_contents)->extension_app(); 60 extensions::TabHelper::FromWebContents(web_contents)->extension_app();
60 DCHECK(extension); 61 DCHECK(extension);
61 value->SetString(kAppID, extension->id()); 62 value->SetString(kAppID, extension->id());
62 // For apps we use the launch url. We do this because the user is 63 // For apps we use the launch url. We do this because the user is
63 // effectively restarting the app, so returning them to the app's launch 64 // effectively restarting the app, so returning them to the app's launch
64 // page seems closest to what they expect. 65 // page seems closest to what they expect.
65 value->SetString(kURL, extension->GetFullLaunchURL().spec()); 66 value->SetString(
67 kURL, extensions::AppLauncherInfo::GetFullLaunchURL(extension).spec());
66 values->Append(value.release()); 68 values->Append(value.release());
67 } else { 69 } else {
68 NavigationEntry* entry = web_contents->GetController().GetActiveEntry(); 70 NavigationEntry* entry = web_contents->GetController().GetActiveEntry();
69 if (!entry && web_contents->GetController().GetEntryCount()) 71 if (!entry && web_contents->GetController().GetEntryCount())
70 entry = web_contents->GetController().GetEntryAtIndex(0); 72 entry = web_contents->GetController().GetEntryAtIndex(0);
71 if (entry) { 73 if (entry) {
72 value->SetString(kURL, entry->GetURL().spec()); 74 value->SetString(kURL, entry->GetURL().spec());
73 values->Append(value.release()); 75 values->Append(value.release());
74 } 76 }
75 } 77 }
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
154 for (size_t i = 0, max = tabs_list->GetSize(); i < max; ++i) { 156 for (size_t i = 0, max = tabs_list->GetSize(); i < max; ++i) {
155 const base::DictionaryValue* tab_values = NULL; 157 const base::DictionaryValue* tab_values = NULL;
156 if (tabs_list->GetDictionary(i, &tab_values)) { 158 if (tabs_list->GetDictionary(i, &tab_values)) {
157 StartupTab tab; 159 StartupTab tab;
158 if (DecodeTab(*tab_values, &tab)) 160 if (DecodeTab(*tab_values, &tab))
159 results.push_back(tab); 161 results.push_back(tab);
160 } 162 }
161 } 163 }
162 return results; 164 return results;
163 } 165 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698