Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Side by Side Diff: chrome/browser/extensions/api/developer_private/developer_private_api.cc

Issue 14241002: Move the parsing of app.launch related keys out of Extension class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/developer_private/developer_private_api. h" 5 #include "chrome/browser/extensions/api/developer_private/developer_private_api. h"
6 6
7 #include "base/base64.h" 7 #include "base/base64.h"
8 #include "base/file_util.h" 8 #include "base/file_util.h"
9 #include "base/strings/string_number_conversions.h" 9 #include "base/strings/string_number_conversions.h"
10 #include "base/utf_string_conversions.h" 10 #include "base/utf_string_conversions.h"
11 #include "base/values.h" 11 #include "base/values.h"
12 #include "chrome/browser/devtools/devtools_window.h" 12 #include "chrome/browser/devtools/devtools_window.h"
13 #include "chrome/browser/extensions/api/developer_private/developer_private_api_ factory.h" 13 #include "chrome/browser/extensions/api/developer_private/developer_private_api_ factory.h"
14 #include "chrome/browser/extensions/api/developer_private/entry_picker.h" 14 #include "chrome/browser/extensions/api/developer_private/entry_picker.h"
15 #include "chrome/browser/extensions/extension_disabled_ui.h" 15 #include "chrome/browser/extensions/extension_disabled_ui.h"
16 #include "chrome/browser/extensions/extension_error_reporter.h" 16 #include "chrome/browser/extensions/extension_error_reporter.h"
17 #include "chrome/browser/extensions/extension_service.h" 17 #include "chrome/browser/extensions/extension_service.h"
18 #include "chrome/browser/extensions/extension_system.h" 18 #include "chrome/browser/extensions/extension_system.h"
19 #include "chrome/browser/extensions/management_policy.h" 19 #include "chrome/browser/extensions/management_policy.h"
20 #include "chrome/browser/extensions/shell_window_registry.h" 20 #include "chrome/browser/extensions/shell_window_registry.h"
21 #include "chrome/browser/extensions/unpacked_installer.h" 21 #include "chrome/browser/extensions/unpacked_installer.h"
22 #include "chrome/browser/extensions/updater/extension_updater.h" 22 #include "chrome/browser/extensions/updater/extension_updater.h"
23 #include "chrome/browser/platform_util.h" 23 #include "chrome/browser/platform_util.h"
24 #include "chrome/browser/profiles/profile.h" 24 #include "chrome/browser/profiles/profile.h"
25 #include "chrome/browser/sync_file_system/drive_file_sync_service.h" 25 #include "chrome/browser/sync_file_system/drive_file_sync_service.h"
26 #include "chrome/browser/ui/chrome_select_file_policy.h" 26 #include "chrome/browser/ui/chrome_select_file_policy.h"
27 #include "chrome/browser/ui/extensions/shell_window.h" 27 #include "chrome/browser/ui/extensions/shell_window.h"
28 #include "chrome/browser/ui/webui/extensions/extension_icon_source.h" 28 #include "chrome/browser/ui/webui/extensions/extension_icon_source.h"
29 #include "chrome/common/extensions/api/developer_private.h" 29 #include "chrome/common/extensions/api/developer_private.h"
30 #include "chrome/common/extensions/app_launcher_info.h"
30 #include "chrome/common/extensions/background_info.h" 31 #include "chrome/common/extensions/background_info.h"
31 #include "chrome/common/extensions/extension_icon_set.h" 32 #include "chrome/common/extensions/extension_icon_set.h"
32 #include "chrome/common/extensions/incognito_handler.h" 33 #include "chrome/common/extensions/incognito_handler.h"
33 #include "chrome/common/extensions/manifest_handlers/icons_handler.h" 34 #include "chrome/common/extensions/manifest_handlers/icons_handler.h"
34 #include "chrome/common/extensions/manifest_handlers/offline_enabled_info.h" 35 #include "chrome/common/extensions/manifest_handlers/offline_enabled_info.h"
35 #include "chrome/common/extensions/manifest_url_handler.h" 36 #include "chrome/common/extensions/manifest_url_handler.h"
36 #include "content/public/browser/browser_thread.h" 37 #include "content/public/browser/browser_thread.h"
37 #include "content/public/browser/render_process_host.h" 38 #include "content/public/browser/render_process_host.h"
38 #include "content/public/browser/render_view_host.h" 39 #include "content/public/browser/render_view_host.h"
39 #include "content/public/browser/storage_partition.h" 40 #include "content/public/browser/storage_partition.h"
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
187 new std::string(ManifestURL::GetOptionsPage(&item).spec())); 188 new std::string(ManifestURL::GetOptionsPage(&item).spec()));
188 } 189 }
189 190
190 if (!ManifestURL::GetUpdateURL(&item).is_empty()) { 191 if (!ManifestURL::GetUpdateURL(&item).is_empty()) {
191 info->update_url.reset( 192 info->update_url.reset(
192 new std::string(ManifestURL::GetUpdateURL(&item).spec())); 193 new std::string(ManifestURL::GetUpdateURL(&item).spec()));
193 } 194 }
194 195
195 if (item.is_app()) { 196 if (item.is_app()) {
196 info->app_launch_url.reset(new std::string( 197 info->app_launch_url.reset(new std::string(
197 item.GetFullLaunchURL().spec())); 198 extensions::AppLauncherInfo::GetFullLaunchURL(&item).spec()));
198 } 199 }
199 200
200 info->may_disable = system->management_policy()-> 201 info->may_disable = system->management_policy()->
201 UserMayModifySettings(&item, NULL); 202 UserMayModifySettings(&item, NULL);
202 info->is_app = item.is_app(); 203 info->is_app = item.is_app();
203 info->views = GetInspectablePagesForExtension(&item, item_is_enabled); 204 info->views = GetInspectablePagesForExtension(&item, item_is_enabled);
204 205
205 return info.Pass(); 206 return info.Pass();
206 } 207 }
207 208
(...skipping 803 matching lines...) Expand 10 before | Expand all | Expand 10 after
1011 1012
1012 #undef SET_STRING 1013 #undef SET_STRING
1013 return true; 1014 return true;
1014 } 1015 }
1015 1016
1016 DeveloperPrivateGetStringsFunction::~DeveloperPrivateGetStringsFunction() {} 1017 DeveloperPrivateGetStringsFunction::~DeveloperPrivateGetStringsFunction() {}
1017 1018
1018 } // namespace api 1019 } // namespace api
1019 1020
1020 } // namespace extensions 1021 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698