chrome/browser/ui/browser_browsertest.cc - Issue 14241002: Move the parsing of app.launch related keys out of Extension class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_browsertest.cc

Issue 14241002: Move the parsing of app.launch related keys out of Extension class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_service.cc ('K') | « chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc ('k') | chrome/browser/ui/extensions/application_launch.cc » ('j') | chrome/common/extensions/app_launcher_info.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser_browsertest.cc

diff --git a/chrome/browser/ui/browser_browsertest.cc b/chrome/browser/ui/browser_browsertest.cc

index e2531022493c7990592cc89a11f579021b709e37..27a2f16a2105971eb608afd805cc8f8e6796980f 100644

--- a/chrome/browser/ui/browser_browsertest.cc

+++ b/chrome/browser/ui/browser_browsertest.cc

@@ -45,6 +45,7 @@

#include "chrome/browser/ui/tabs/tab_strip_model.h"

#include "chrome/common/chrome_notification_types.h"

#include "chrome/common/chrome_switches.h"

+#include "chrome/common/extensions/app_launcher_info.h"

#include "chrome/common/extensions/extension.h"

#include "chrome/common/url_constants.h"

#include "chrome/test/base/in_process_browser_test.h"

@@ -1142,7 +1143,8 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, OpenAppWindowLikeNtp) {

ASSERT_TRUE(extensions::TabHelper::FromWebContents(app_window));

EXPECT_FALSE(

extensions::TabHelper::FromWebContents(app_window)->extension_app());

- EXPECT_EQ(extension_app->GetFullLaunchURL(), app_window->GetURL());

+ EXPECT_EQ(extensions::AppLauncherInfo::GetFullLaunchURL(extension_app),

+ app_window->GetURL());

// The launch should have created a new browser.

ASSERT_EQ(2u, chrome::GetBrowserCount(browser()->profile(),