Revise attribute binding interface

Revise attribute binding interface.

Replace the old attribute binding and index interface with one where we include the binding as part of the attribute array. Also removed the fixed attribute indices for constant color and coverage attributes, and replaced with dynamic ones based on current attribute set. Removed binding of color and coverage attributes unless they're actually set.

Original author: bsalomon@google.com

Committed: http://code.google.com/p/skia/source/detail?r=8466

[bsalomon, 2013-03-29 21:18:13]

https://codereview.chromium.org/13296005/diff/1/src/gpu/GrDrawState.cpp
File src/gpu/GrDrawState.cpp (right):

https://codereview.chromium.org/13296005/diff/1/src/gpu/GrDrawState.cpp#newco...
src/gpu/GrDrawState.cpp:123: #if GR_DEBUG
I think I added this in support of asserts for code that I later removed. It
doesn't appear to be used.

https://codereview.chromium.org/13296005/diff/1/src/gpu/GrDrawState.h
File src/gpu/GrDrawState.h (right):

https://codereview.chromium.org/13296005/diff/1/src/gpu/GrDrawState.h#newcode60
src/gpu/GrDrawState.h:60: #if 0 && GR_DEBUG
Let's just remove this. I see the test is gone. (This was never the right place
to call it anyway)

[jvanverth1, 2013-03-29 21:32:45]

I also, as we discussed, changed setColor and setCoverage to always clear the
stored constant attribute index unless we're using a constant attribute. I
suspect we could end up setting the attribute again in cases where we don't need
to, but it may not be frequent enough to warrant additional complexity.

https://codereview.chromium.org/13296005/diff/1/src/gpu/GrDrawState.cpp
File src/gpu/GrDrawState.cpp (right):

https://codereview.chromium.org/13296005/diff/1/src/gpu/GrDrawState.cpp#newco...
src/gpu/GrDrawState.cpp:123: #if GR_DEBUG
On 2013/03/29 21:18:13, bsalomon wrote:
> I think I added this in support of asserts for code that I later removed. It
> doesn't appear to be used.

Done.

https://codereview.chromium.org/13296005/diff/1/src/gpu/GrDrawState.h
File src/gpu/GrDrawState.h (right):

https://codereview.chromium.org/13296005/diff/1/src/gpu/GrDrawState.h#newcode60
src/gpu/GrDrawState.h:60: #if 0 && GR_DEBUG
On 2013/03/29 21:18:13, bsalomon wrote:
> Let's just remove this. I see the test is gone. (This was never the right
place
> to call it anyway)

Done.

[bsalomon, 2013-03-29 21:48:10]

lgtm

[commit-bot: I haz the power, 2013-04-01 19:12:20]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/jvanverth@google.com/13296005/21002

[commit-bot: I haz the power, 2013-04-01 19:13:29]

Change committed as 8466