Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 12848005: [chromedriver] Separate stuff of chrome from chromedriver. (Closed)

Created:
7 years, 9 months ago by chrisgao (Use stgao instead)
Modified:
7 years, 9 months ago
Reviewers:
craigdh, kkania, frankf
CC:
chromium-reviews, yurys, vsevik, pfeldman, sail+watch_chromium.org
Visibility:
Public.

Description

[chromedriver] Separate stuff of chrome from chromedriver. Do some refactoring. Move all stuff about chrome into a sub directory. Also, delete file chrome_launcher_impl.cc. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188410

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments and fix compile error on mac. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+376 lines, -7190 lines) Patch
M chrome/chrome_tests.gypi View 1 7 chunks +129 lines, -105 lines 0 comments Download
M chrome/test/chromedriver/README.txt View 1 2 chunks +27 lines, -3 lines 0 comments Download
D chrome/test/chromedriver/adb_commands.py View 1 chunk +0 lines, -168 lines 0 comments Download
D chrome/test/chromedriver/chrome.h View 1 chunk +0 lines, -40 lines 0 comments Download
A + chrome/test/chromedriver/chrome/adb_commands.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/chromedriver/chrome/chrome.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/test/chromedriver/chrome/chrome_android_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/test/chromedriver/chrome/chrome_android_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/test/chromedriver/chrome/chrome_desktop_impl.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + chrome/test/chromedriver/chrome/chrome_desktop_impl.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/test/chromedriver/chrome/chrome_desktop_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/test/chromedriver/chrome/chrome_finder.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/test/chromedriver/chrome/chrome_finder.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/test/chromedriver/chrome/chrome_finder_mac.mm View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/chromedriver/chrome/chrome_finder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/test/chromedriver/chrome/chrome_impl.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + chrome/test/chromedriver/chrome/chrome_impl.cc View 2 chunks +6 lines, -6 lines 0 comments Download
A + chrome/test/chromedriver/chrome/chrome_impl_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/test/chromedriver/chrome/devtools_client.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/test/chromedriver/chrome/devtools_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/test/chromedriver/chrome/devtools_client_impl.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + chrome/test/chromedriver/chrome/devtools_client_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/test/chromedriver/chrome/devtools_event_listener.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/test/chromedriver/chrome/dom_tracker.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/test/chromedriver/chrome/dom_tracker.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/test/chromedriver/chrome/dom_tracker_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/test/chromedriver/chrome/frame_tracker.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/test/chromedriver/chrome/frame_tracker.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/test/chromedriver/chrome/frame_tracker_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/test/chromedriver/chrome/javascript_dialog_manager.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/test/chromedriver/chrome/javascript_dialog_manager.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/test/chromedriver/chrome/javascript_dialog_manager_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/test/chromedriver/chrome/local_state.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/chromedriver/chrome/navigation_tracker.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/test/chromedriver/chrome/navigation_tracker.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/test/chromedriver/chrome/navigation_tracker_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/test/chromedriver/chrome/preferences.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/chromedriver/chrome/status.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/test/chromedriver/chrome/status.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/test/chromedriver/chrome/status_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/test/chromedriver/chrome/stub_chrome.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/test/chromedriver/chrome/stub_chrome.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/test/chromedriver/chrome/stub_devtools_client.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/test/chromedriver/chrome/stub_devtools_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/test/chromedriver/chrome/stub_web_view.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/test/chromedriver/chrome/stub_web_view.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/test/chromedriver/chrome/ui_events.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/test/chromedriver/chrome/ui_events.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/test/chromedriver/chrome/version.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/test/chromedriver/chrome/version.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/test/chromedriver/chrome/web_view.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/test/chromedriver/chrome/web_view_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/test/chromedriver/chrome/web_view_impl.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + chrome/test/chromedriver/chrome/web_view_impl.cc View 1 chunk +10 lines, -10 lines 0 comments Download
A + chrome/test/chromedriver/chrome/web_view_impl_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/test/chromedriver/chrome/zip.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/test/chromedriver/chrome/zip.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/test/chromedriver/chrome/zip_internal.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/test/chromedriver/chrome/zip_internal.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/test/chromedriver/chrome/zip_reader.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/test/chromedriver/chrome/zip_reader.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/test/chromedriver/chrome_android_impl.h View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/test/chromedriver/chrome_android_impl.cc View 1 chunk +0 lines, -67 lines 0 comments Download
D chrome/test/chromedriver/chrome_desktop_impl.h View 1 chunk +0 lines, -64 lines 0 comments Download
D chrome/test/chromedriver/chrome_desktop_impl.cc View 1 chunk +0 lines, -240 lines 0 comments Download
D chrome/test/chromedriver/chrome_desktop_impl_unittest.cc View 1 chunk +0 lines, -157 lines 0 comments Download
D chrome/test/chromedriver/chrome_finder.h View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/test/chromedriver/chrome_finder.cc View 1 chunk +0 lines, -116 lines 0 comments Download
D chrome/test/chromedriver/chrome_finder_mac.mm View 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/test/chromedriver/chrome_finder_unittest.cc View 1 chunk +0 lines, -107 lines 0 comments Download
D chrome/test/chromedriver/chrome_impl.h View 1 chunk +0 lines, -91 lines 0 comments Download
D chrome/test/chromedriver/chrome_impl.cc View 1 chunk +0 lines, -432 lines 0 comments Download
D chrome/test/chromedriver/chrome_impl_unittest.cc View 1 chunk +0 lines, -160 lines 0 comments Download
D chrome/test/chromedriver/chrome_launcher_impl.cc View 1 chunk +0 lines, -62 lines 0 comments Download
M chrome/test/chromedriver/chromedriver.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/chromedriver_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/command_executor.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/command_executor_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/command_executor_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/command_executor_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/commands.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/test/chromedriver/commands_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
D chrome/test/chromedriver/devtools_client.h View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/test/chromedriver/devtools_client.cc View 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/test/chromedriver/devtools_client_impl.h View 1 chunk +0 lines, -127 lines 0 comments Download
D chrome/test/chromedriver/devtools_client_impl.cc View 1 chunk +0 lines, -300 lines 0 comments Download
D chrome/test/chromedriver/devtools_client_impl_unittest.cc View 1 chunk +0 lines, -816 lines 0 comments Download
D chrome/test/chromedriver/devtools_event_listener.h View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/test/chromedriver/dom_tracker.h View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/test/chromedriver/dom_tracker.cc View 1 chunk +0 lines, -87 lines 0 comments Download
D chrome/test/chromedriver/dom_tracker_unittest.cc View 1 chunk +0 lines, -73 lines 0 comments Download
M chrome/test/chromedriver/element_commands.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/test/chromedriver/element_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/chromedriver/embed_js_in_cpp.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/embed_user_data_dir_in_cpp.py View 1 chunk +1 line, -1 line 0 comments Download
D chrome/test/chromedriver/frame_tracker.h View 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/test/chromedriver/frame_tracker.cc View 1 chunk +0 lines, -73 lines 0 comments Download
D chrome/test/chromedriver/frame_tracker_unittest.cc View 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/test/chromedriver/javascript_dialog_manager.h View 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/test/chromedriver/javascript_dialog_manager.cc View 1 chunk +0 lines, -72 lines 0 comments Download
D chrome/test/chromedriver/javascript_dialog_manager_unittest.cc View 1 chunk +0 lines, -178 lines 0 comments Download
M chrome/test/chromedriver/key_converter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/key_converter_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/keycode_text_conversion_mac.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/keycode_text_conversion_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/keycode_text_conversion_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/keycode_text_conversion_x.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/test/chromedriver/local_state.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D chrome/test/chromedriver/navigation_tracker.h View 1 chunk +0 lines, -51 lines 0 comments Download
D chrome/test/chromedriver/navigation_tracker.cc View 1 chunk +0 lines, -121 lines 0 comments Download
D chrome/test/chromedriver/navigation_tracker_unittest.cc View 1 chunk +0 lines, -187 lines 0 comments Download
D chrome/test/chromedriver/preferences.txt View 1 chunk +0 lines, -47 lines 0 comments Download
M chrome/test/chromedriver/server/chromedriver_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/server/http_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/server/http_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/session.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/test/chromedriver/session_commands.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/chromedriver/session_commands_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/session_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
D chrome/test/chromedriver/status.h View 1 chunk +0 lines, -58 lines 0 comments Download
D chrome/test/chromedriver/status.cc View 1 chunk +0 lines, -102 lines 0 comments Download
D chrome/test/chromedriver/status_unittest.cc View 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/test/chromedriver/stub_chrome.h View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/test/chromedriver/stub_chrome.cc View 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/test/chromedriver/stub_devtools_client.h View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/test/chromedriver/stub_devtools_client.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/test/chromedriver/stub_web_view.h View 1 chunk +0 lines, -64 lines 0 comments Download
D chrome/test/chromedriver/stub_web_view.cc View 1 chunk +0 lines, -90 lines 0 comments Download
D chrome/test/chromedriver/ui_events.h View 1 chunk +0 lines, -78 lines 0 comments Download
D chrome/test/chromedriver/ui_events.cc View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/test/chromedriver/version.h View 1 chunk +0 lines, -15 lines 0 comments Download
D chrome/test/chromedriver/version.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/test/chromedriver/web_view.h View 1 chunk +0 lines, -99 lines 0 comments Download
D chrome/test/chromedriver/web_view_delegate.h View 1 chunk +0 lines, -18 lines 0 comments Download
D chrome/test/chromedriver/web_view_impl.h View 1 chunk +0 lines, -112 lines 0 comments Download
D chrome/test/chromedriver/web_view_impl.cc View 1 chunk +0 lines, -438 lines 0 comments Download
D chrome/test/chromedriver/web_view_impl_unittest.cc View 1 chunk +0 lines, -202 lines 0 comments Download
M chrome/test/chromedriver/window_commands.cc View 1 chunk +5 lines, -5 lines 0 comments Download
D chrome/test/chromedriver/zip.h View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/test/chromedriver/zip.cc View 1 chunk +0 lines, -207 lines 0 comments Download
D chrome/test/chromedriver/zip_internal.h View 1 chunk +0 lines, -62 lines 0 comments Download
D chrome/test/chromedriver/zip_internal.cc View 1 chunk +0 lines, -316 lines 0 comments Download
D chrome/test/chromedriver/zip_reader.h View 1 chunk +0 lines, -177 lines 0 comments Download
D chrome/test/chromedriver/zip_reader.cc View 1 chunk +0 lines, -310 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
chrisgao (Use stgao instead)
Did some refactoring. ptal
7 years, 9 months ago (2013-03-14 22:59:04 UTC) #1
kkania
update the README.txt, so that people can understand the distinction https://codereview.chromium.org/12848005/diff/1/chrome/chrome_tests.gypi File chrome/chrome_tests.gypi (right): https://codereview.chromium.org/12848005/diff/1/chrome/chrome_tests.gypi#newcode733 ...
7 years, 9 months ago (2013-03-14 23:13:04 UTC) #2
chrisgao (Use stgao instead)
ptal https://codereview.chromium.org/12848005/diff/1/chrome/chrome_tests.gypi File chrome/chrome_tests.gypi (right): https://codereview.chromium.org/12848005/diff/1/chrome/chrome_tests.gypi#newcode733 chrome/chrome_tests.gypi:733: '../ui/ui.gyp:ui', On 2013/03/14 23:13:05, kkania wrote: > you ...
7 years, 9 months ago (2013-03-15 00:26:31 UTC) #3
kkania
lgtm if tests pass
7 years, 9 months ago (2013-03-15 00:43:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrisgao@chromium.org/12848005/7001
7 years, 9 months ago (2013-03-15 16:16:46 UTC) #5
commit-bot: I haz the power
Change committed as 188410
7 years, 9 months ago (2013-03-15 16:20:04 UTC) #6
frankf
On 2013/03/15 16:20:04, I haz the power (commit-bot) wrote: > Change committed as 188410 This ...
7 years, 9 months ago (2013-03-15 17:27:21 UTC) #7
frankf
7 years, 9 months ago (2013-03-15 17:33:55 UTC) #8
Message was sent while issue was closed.
Also, the path to version.cc needs to be udpated:

http://chromegw/i/chromium.pyauto/builders/Linux%20QA/builds/1557/steps/chrom...

On 2013/03/15 17:27:21, frankf wrote:
> On 2013/03/15 16:20:04, I haz the power (commit-bot) wrote:
> > Change committed as 188410
> 
> This caused failures on Android:
> 
>
http://build.chromium.org/p/chromium.fyi/builders/Android%2520ChromeDriver%25...

Powered by Google App Engine
This is Rietveld 408576698