chrome/test/chromedriver/chrome/chrome_desktop_impl.cc - Issue 12848005: [chromedriver] Separate stuff of chrome from chromedriver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/chrome_desktop_impl.cc

Issue 12848005: [chromedriver] Separate stuff of chrome from chromedriver. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments and fix compile error on mac. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/chrome/chrome_desktop_impl.cc

diff --git a/chrome/test/chromedriver/chrome_desktop_impl.cc b/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc

similarity index 96%

rename from chrome/test/chromedriver/chrome_desktop_impl.cc

rename to chrome/test/chromedriver/chrome/chrome_desktop_impl.cc

index 42488b3e3363d503fee2c7faff2c3420d151370f..f94a957bbee3d8cc7ae8c39a25166d7c34125529 100644

--- a/chrome/test/chromedriver/chrome_desktop_impl.cc

+++ b/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc

@@ -2,7 +2,7 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-#include "chrome/test/chromedriver/chrome_desktop_impl.h"

+#include "chrome/test/chromedriver/chrome/chrome_desktop_impl.h"

#include "base/base64.h"

#include "base/command_line.h"

@@ -19,12 +19,12 @@

#include "base/sys_info.h"

#include "base/utf_string_conversions.h"

#include "base/values.h"

-#include "chrome/common/zip.h"

-#include "chrome/test/chromedriver/chrome_finder.h"

+#include "chrome/test/chromedriver/chrome/chrome_finder.h"

+#include "chrome/test/chromedriver/chrome/status.h"

+#include "chrome/test/chromedriver/chrome/user_data_dir.h"

+#include "chrome/test/chromedriver/chrome/zip.h"

#include "chrome/test/chromedriver/net/sync_websocket_impl.h"

#include "chrome/test/chromedriver/net/url_request_context_getter.h"

-#include "chrome/test/chromedriver/status.h"

-#include "chrome/test/chromedriver/user_data_dir.h"

ChromeDesktopImpl::ChromeDesktopImpl(

URLRequestContextGetter* context_getter,