chrome/test/chromedriver/chrome/javascript_dialog_manager.cc - Issue 12848005: [chromedriver] Separate stuff of chrome from chromedriver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/javascript_dialog_manager.cc

Issue 12848005: [chromedriver] Separate stuff of chrome from chromedriver. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments and fix compile error on mac. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/chrome/javascript_dialog_manager.cc

diff --git a/chrome/test/chromedriver/javascript_dialog_manager.cc b/chrome/test/chromedriver/chrome/javascript_dialog_manager.cc

similarity index 92%

rename from chrome/test/chromedriver/javascript_dialog_manager.cc

rename to chrome/test/chromedriver/chrome/javascript_dialog_manager.cc

index ed8aa70c84e5d35e70533a3fc43d6c3fad4b7d6c..a8eb7cdc59af6488ef0cbd0dd6ddc1a9111c12d1 100644

--- a/chrome/test/chromedriver/javascript_dialog_manager.cc

+++ b/chrome/test/chromedriver/chrome/javascript_dialog_manager.cc

@@ -2,12 +2,12 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-#include "chrome/test/chromedriver/javascript_dialog_manager.h"

+#include "chrome/test/chromedriver/chrome/javascript_dialog_manager.h"

#include "base/logging.h"

#include "base/values.h"

-#include "chrome/test/chromedriver/devtools_client.h"

-#include "chrome/test/chromedriver/status.h"

+#include "chrome/test/chromedriver/chrome/devtools_client.h"

+#include "chrome/test/chromedriver/chrome/status.h"

JavaScriptDialogManager::JavaScriptDialogManager(DevToolsClient* client)

: client_(client) {