Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1222)

Unified Diff: chrome/test/chromedriver/chrome_launcher_impl.cc

Issue 12848005: [chromedriver] Separate stuff of chrome from chromedriver. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments and fix compile error on mac. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/chrome_impl_unittest.cc ('k') | chrome/test/chromedriver/chromedriver.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/chrome_launcher_impl.cc
diff --git a/chrome/test/chromedriver/chrome_launcher_impl.cc b/chrome/test/chromedriver/chrome_launcher_impl.cc
deleted file mode 100644
index e811582dce0a4d4550d6478e24d1cddcec509319..0000000000000000000000000000000000000000
--- a/chrome/test/chromedriver/chrome_launcher_impl.cc
+++ /dev/null
@@ -1,62 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/test/chromedriver/chrome_launcher_impl.h"
-
-#include <string>
-
-#include "base/command_line.h"
-#include "base/files/file_path.h"
-#include "base/process.h"
-#include "base/process_util.h"
-#include "base/stringprintf.h"
-#include "base/strings/string_number_conversions.h"
-#include "chrome/test/chromedriver/chrome.h"
-#include "chrome/test/chromedriver/chrome_finder.h"
-#include "chrome/test/chromedriver/chrome_impl.h"
-#include "chrome/test/chromedriver/net/url_request_context_getter.h"
-#include "chrome/test/chromedriver/status.h"
-#include "chrome/test/chromedriver/version.h"
-
-ChromeLauncherImpl::ChromeLauncherImpl(
- URLRequestContextGetter* context_getter,
- const SyncWebSocketFactory& socket_factory)
- : context_getter_(context_getter),
- socket_factory_(socket_factory) {}
-
-ChromeLauncherImpl::~ChromeLauncherImpl() {}
-
-Status ChromeLauncherImpl::Launch(
- const base::FilePath& chrome_exe,
- scoped_ptr<Chrome>* chrome) {
- base::FilePath program = chrome_exe;
- if (program.empty()) {
- if (!FindChrome(&program))
- return Status(kUnknownError, "cannot find Chrome binary");
- }
-
- int port = 33081;
- CommandLine command(program);
- command.AppendSwitchASCII("remote-debugging-port", base::IntToString(port));
- command.AppendSwitch("no-first-run");
- command.AppendSwitch("enable-logging");
- command.AppendSwitchASCII("logging-level", "1");
- base::ScopedTempDir user_data_dir;
- if (!user_data_dir.CreateUniqueTempDir())
- return Status(kUnknownError, "cannot create temp dir for user data dir");
- command.AppendSwitchPath("user-data-dir", user_data_dir.path());
- command.AppendArg("data:text/html;charset=utf-8,");
-
- base::LaunchOptions options;
- base::ProcessHandle process;
- if (!base::LaunchProcess(command, options, &process))
- return Status(kUnknownError, "chrome failed to start");
- scoped_ptr<ChromeImpl> chrome_impl(new ChromeImpl(
- process, context_getter_, &user_data_dir, port, socket_factory_));
- Status status = chrome_impl->Init();
- if (status.IsError())
- return status;
- chrome->reset(chrome_impl.release());
- return Status(kOk);
-}
« no previous file with comments | « chrome/test/chromedriver/chrome_impl_unittest.cc ('k') | chrome/test/chromedriver/chromedriver.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698