Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4988)

Unified Diff: chrome/test/chromedriver/web_view_impl_unittest.cc

Issue 12848005: [chromedriver] Separate stuff of chrome from chromedriver. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments and fix compile error on mac. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/web_view_impl.cc ('k') | chrome/test/chromedriver/window_commands.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/web_view_impl_unittest.cc
diff --git a/chrome/test/chromedriver/web_view_impl_unittest.cc b/chrome/test/chromedriver/web_view_impl_unittest.cc
deleted file mode 100644
index 66e3d7f762cd2532b180d49d6b0c87e932809b3e..0000000000000000000000000000000000000000
--- a/chrome/test/chromedriver/web_view_impl_unittest.cc
+++ /dev/null
@@ -1,202 +0,0 @@
-// Copyright (c) 2013 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include <list>
-#include <string>
-
-#include "base/compiler_specific.h"
-#include "base/memory/scoped_ptr.h"
-#include "base/values.h"
-#include "chrome/test/chromedriver/devtools_client.h"
-#include "chrome/test/chromedriver/status.h"
-#include "chrome/test/chromedriver/web_view_impl.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-namespace {
-
-class FakeDevToolsClient : public DevToolsClient {
- public:
- FakeDevToolsClient() : status_(kOk) {}
- virtual ~FakeDevToolsClient() {}
-
- void set_status(const Status& status) {
- status_ = status;
- }
- void set_result(const base::DictionaryValue& result) {
- result_.Clear();
- result_.MergeDictionary(&result);
- }
-
- // Overridden from DevToolsClient:
- virtual Status ConnectIfNecessary() OVERRIDE {
- return Status(kOk);
- }
- virtual Status SendCommand(const std::string& method,
- const base::DictionaryValue& params) OVERRIDE {
- return SendCommandAndGetResult(method, params, NULL);
- }
- virtual Status SendCommandAndGetResult(
- const std::string& method,
- const base::DictionaryValue& params,
- scoped_ptr<base::DictionaryValue>* result) OVERRIDE {
- if (status_.IsError())
- return status_;
- result->reset(result_.DeepCopy());
- return Status(kOk);
- }
- virtual void AddListener(DevToolsEventListener* listener) OVERRIDE {}
- virtual Status HandleEventsUntil(
- const ConditionalFunc& conditional_func) OVERRIDE {
- return Status(kOk);
- }
-
- private:
- Status status_;
- base::DictionaryValue result_;
-};
-
-void AssertEvalFails(const base::DictionaryValue& command_result) {
- scoped_ptr<base::DictionaryValue> result;
- FakeDevToolsClient client;
- client.set_result(command_result);
- Status status = internal::EvaluateScript(&client, 0, "",
- internal::ReturnByValue, &result);
- ASSERT_EQ(kUnknownError, status.code());
- ASSERT_FALSE(result);
-}
-
-} // namespace
-
-TEST(EvaluateScript, CommandError) {
- scoped_ptr<base::DictionaryValue> result;
- FakeDevToolsClient client;
- client.set_status(Status(kUnknownError));
- Status status = internal::EvaluateScript(&client, 0, "",
- internal::ReturnByValue, &result);
- ASSERT_EQ(kUnknownError, status.code());
- ASSERT_FALSE(result);
-}
-
-TEST(EvaluateScript, MissingWasThrown) {
- base::DictionaryValue dict;
- ASSERT_NO_FATAL_FAILURE(AssertEvalFails(dict));
-}
-
-TEST(EvaluateScript, MissingResult) {
- base::DictionaryValue dict;
- dict.SetBoolean("wasThrown", false);
- ASSERT_NO_FATAL_FAILURE(AssertEvalFails(dict));
-}
-
-TEST(EvaluateScript, Throws) {
- base::DictionaryValue dict;
- dict.SetBoolean("wasThrown", true);
- dict.SetString("result.type", "undefined");
- ASSERT_NO_FATAL_FAILURE(AssertEvalFails(dict));
-}
-
-TEST(EvaluateScript, Ok) {
- scoped_ptr<base::DictionaryValue> result;
- base::DictionaryValue dict;
- dict.SetBoolean("wasThrown", false);
- dict.SetInteger("result.key", 100);
- FakeDevToolsClient client;
- client.set_result(dict);
- ASSERT_TRUE(internal::EvaluateScript(
- &client, 0, "", internal::ReturnByValue, &result).IsOk());
- ASSERT_TRUE(result);
- ASSERT_TRUE(result->HasKey("key"));
-}
-
-TEST(EvaluateScriptAndGetValue, MissingType) {
- scoped_ptr<base::Value> result;
- FakeDevToolsClient client;
- base::DictionaryValue dict;
- dict.SetBoolean("wasThrown", false);
- dict.SetInteger("result.value", 1);
- client.set_result(dict);
- ASSERT_TRUE(internal::EvaluateScriptAndGetValue(
- &client, 0, "", &result).IsError());
-}
-
-TEST(EvaluateScriptAndGetValue, Undefined) {
- scoped_ptr<base::Value> result;
- FakeDevToolsClient client;
- base::DictionaryValue dict;
- dict.SetBoolean("wasThrown", false);
- dict.SetString("result.type", "undefined");
- client.set_result(dict);
- Status status = internal::EvaluateScriptAndGetValue(
- &client, 0, "", &result);
- ASSERT_EQ(kOk, status.code());
- ASSERT_TRUE(result && result->IsType(base::Value::TYPE_NULL));
-}
-
-TEST(EvaluateScriptAndGetValue, Ok) {
- scoped_ptr<base::Value> result;
- FakeDevToolsClient client;
- base::DictionaryValue dict;
- dict.SetBoolean("wasThrown", false);
- dict.SetString("result.type", "integer");
- dict.SetInteger("result.value", 1);
- client.set_result(dict);
- Status status = internal::EvaluateScriptAndGetValue(
- &client, 0, "", &result);
- ASSERT_EQ(kOk, status.code());
- int value;
- ASSERT_TRUE(result && result->GetAsInteger(&value));
- ASSERT_EQ(1, value);
-}
-
-TEST(EvaluateScriptAndGetObject, NoObject) {
- FakeDevToolsClient client;
- base::DictionaryValue dict;
- dict.SetBoolean("wasThrown", false);
- dict.SetString("result.type", "integer");
- client.set_result(dict);
- std::string object_id;
- ASSERT_TRUE(internal::EvaluateScriptAndGetObject(
- &client, 0, "", &object_id).IsError());
- ASSERT_TRUE(object_id.empty());
-}
-
-TEST(EvaluateScriptAndGetObject, Ok) {
- FakeDevToolsClient client;
- base::DictionaryValue dict;
- dict.SetBoolean("wasThrown", false);
- dict.SetString("result.objectId", "id");
- client.set_result(dict);
- std::string object_id;
- ASSERT_TRUE(internal::EvaluateScriptAndGetObject(
- &client, 0, "", &object_id).IsOk());
- ASSERT_STREQ("id", object_id.c_str());
-}
-
-TEST(ParseCallFunctionResult, NotDict) {
- scoped_ptr<base::Value> result;
- base::FundamentalValue value(1);
- ASSERT_NE(kOk, internal::ParseCallFunctionResult(value, &result).code());
-}
-
-TEST(ParseCallFunctionResult, Ok) {
- scoped_ptr<base::Value> result;
- base::DictionaryValue dict;
- dict.SetInteger("status", 0);
- dict.SetInteger("value", 1);
- Status status = internal::ParseCallFunctionResult(dict, &result);
- ASSERT_EQ(kOk, status.code());
- int value;
- ASSERT_TRUE(result && result->GetAsInteger(&value));
- ASSERT_EQ(1, value);
-}
-
-TEST(ParseCallFunctionResult, ScriptError) {
- scoped_ptr<base::Value> result;
- base::DictionaryValue dict;
- dict.SetInteger("status", 1);
- dict.SetInteger("value", 1);
- Status status = internal::ParseCallFunctionResult(dict, &result);
- ASSERT_EQ(1, status.code());
- ASSERT_FALSE(result);
-}
« no previous file with comments | « chrome/test/chromedriver/web_view_impl.cc ('k') | chrome/test/chromedriver/window_commands.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698