Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2972)

Unified Diff: chrome/test/chromedriver/javascript_dialog_manager_unittest.cc

Issue 12848005: [chromedriver] Separate stuff of chrome from chromedriver. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments and fix compile error on mac. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/javascript_dialog_manager.cc ('k') | chrome/test/chromedriver/key_converter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/javascript_dialog_manager_unittest.cc
diff --git a/chrome/test/chromedriver/javascript_dialog_manager_unittest.cc b/chrome/test/chromedriver/javascript_dialog_manager_unittest.cc
deleted file mode 100644
index b990deb8591f0d7947af7b0b928a7612521d30c8..0000000000000000000000000000000000000000
--- a/chrome/test/chromedriver/javascript_dialog_manager_unittest.cc
+++ /dev/null
@@ -1,178 +0,0 @@
-// Copyright (c) 2013 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include <string>
-
-#include "base/callback.h"
-#include "base/memory/scoped_ptr.h"
-#include "base/values.h"
-#include "chrome/test/chromedriver/javascript_dialog_manager.h"
-#include "chrome/test/chromedriver/status.h"
-#include "chrome/test/chromedriver/stub_devtools_client.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-TEST(JavaScriptDialogManager, NoDialog) {
- StubDevToolsClient client;
- JavaScriptDialogManager manager(&client);
- std::string message("HI");
- ASSERT_EQ(kNoAlertOpen, manager.GetDialogMessage(&message).code());
- ASSERT_FALSE(manager.IsDialogOpen());
- ASSERT_STREQ("HI", message.c_str());
- ASSERT_EQ(kNoAlertOpen, manager.HandleDialog(false, "").code());
-}
-
-namespace {
-
-class RecorderDevToolsClient : public StubDevToolsClient {
- public:
- RecorderDevToolsClient() {}
- virtual ~RecorderDevToolsClient() {}
-
- // Overridden from StubDevToolsClient:
- virtual Status SendCommandAndGetResult(
- const std::string& method,
- const base::DictionaryValue& params,
- scoped_ptr<base::DictionaryValue>* result) OVERRIDE {
- method_ = method;
- params_.Clear();
- params_.MergeDictionary(&params);
- return Status(kOk);
- }
-
- std::string method_;
- base::DictionaryValue params_;
-};
-
-} // namespace
-
-TEST(JavaScriptDialogManager, HandleDialogPassesParams) {
- RecorderDevToolsClient client;
- JavaScriptDialogManager manager(&client);
- base::DictionaryValue params;
- params.SetString("message", "hi");
- manager.OnEvent("Page.javascriptDialogOpening", params);
- ASSERT_EQ(kOk, manager.HandleDialog(false, "text").code());
- std::string text;
- client.params_.GetString("promptText", &text);
- ASSERT_EQ("text", text);
- ASSERT_TRUE(client.params_.HasKey("accept"));
-}
-
-TEST(JavaScriptDialogManager, ReconnectClearsStateAndSendsEnable) {
- RecorderDevToolsClient client;
- JavaScriptDialogManager manager(&client);
- base::DictionaryValue params;
- params.SetString("message", "hi");
- manager.OnEvent("Page.javascriptDialogOpening", params);
- ASSERT_TRUE(manager.IsDialogOpen());
- std::string message;
- ASSERT_EQ(kOk, manager.GetDialogMessage(&message).code());
-
- ASSERT_TRUE(manager.OnConnected().IsOk());
- ASSERT_EQ("Page.enable", client.method_);
- ASSERT_FALSE(manager.IsDialogOpen());
- ASSERT_EQ(kNoAlertOpen, manager.GetDialogMessage(&message).code());
- ASSERT_EQ(kNoAlertOpen, manager.HandleDialog(false, "").code());
-}
-
-namespace {
-
-class FakeDevToolsClient : public StubDevToolsClient {
- public:
- FakeDevToolsClient() : listener_(NULL), closing_count_(0) {}
- virtual ~FakeDevToolsClient() {}
-
- void set_closing_count(int closing_count) {
- closing_count_ = closing_count;
- }
-
- // Overridden from StubDevToolsClient:
- virtual Status SendCommandAndGetResult(
- const std::string& method,
- const base::DictionaryValue& params,
- scoped_ptr<base::DictionaryValue>* result) OVERRIDE {
- while (closing_count_ > 0) {
- base::DictionaryValue empty;
- listener_->OnEvent("Page.javascriptDialogClosing", empty);
- closing_count_--;
- }
- return Status(kOk);
- }
- virtual void AddListener(DevToolsEventListener* listener) OVERRIDE {
- listener_ = listener;
- }
-
- private:
- DevToolsEventListener* listener_;
- int closing_count_;
-};
-
-} // namespace
-
-TEST(JavaScriptDialogManager, OneDialog) {
- FakeDevToolsClient client;
- JavaScriptDialogManager manager(&client);
- base::DictionaryValue params;
- params.SetString("message", "hi");
- ASSERT_FALSE(manager.IsDialogOpen());
- std::string message;
- ASSERT_EQ(kNoAlertOpen, manager.GetDialogMessage(&message).code());
-
- manager.OnEvent("Page.javascriptDialogOpening", params);
- ASSERT_TRUE(manager.IsDialogOpen());
- ASSERT_EQ(kOk, manager.GetDialogMessage(&message).code());
- ASSERT_EQ("hi", message);
-
- client.set_closing_count(1);
- ASSERT_EQ(kOk, manager.HandleDialog(false, "").code());
- ASSERT_FALSE(manager.IsDialogOpen());
- ASSERT_EQ(kNoAlertOpen, manager.GetDialogMessage(&message).code());
- ASSERT_EQ(kNoAlertOpen, manager.HandleDialog(false, "").code());
-}
-
-TEST(JavaScriptDialogManager, TwoDialogs) {
- FakeDevToolsClient client;
- JavaScriptDialogManager manager(&client);
- base::DictionaryValue params;
- params.SetString("message", "1");
- manager.OnEvent("Page.javascriptDialogOpening", params);
- params.SetString("message", "2");
- manager.OnEvent("Page.javascriptDialogOpening", params);
-
- std::string message;
- ASSERT_EQ(kOk, manager.GetDialogMessage(&message).code());
- ASSERT_TRUE(manager.IsDialogOpen());
- ASSERT_EQ("1", message);
-
- ASSERT_EQ(kOk, manager.HandleDialog(false, "").code());
- ASSERT_TRUE(manager.IsDialogOpen());
- ASSERT_EQ(kOk, manager.GetDialogMessage(&message).code());
- ASSERT_EQ("2", message);
-
- client.set_closing_count(2);
- ASSERT_EQ(kOk, manager.HandleDialog(false, "").code());
- ASSERT_FALSE(manager.IsDialogOpen());
- ASSERT_EQ(kNoAlertOpen, manager.GetDialogMessage(&message).code());
- ASSERT_EQ(kNoAlertOpen, manager.HandleDialog(false, "").code());
-}
-
-TEST(JavaScriptDialogManager, OneDialogManualClose) {
- StubDevToolsClient client;
- JavaScriptDialogManager manager(&client);
- base::DictionaryValue params;
- params.SetString("message", "hi");
- ASSERT_FALSE(manager.IsDialogOpen());
- std::string message;
- ASSERT_EQ(kNoAlertOpen, manager.GetDialogMessage(&message).code());
-
- manager.OnEvent("Page.javascriptDialogOpening", params);
- ASSERT_TRUE(manager.IsDialogOpen());
- ASSERT_EQ(kOk, manager.GetDialogMessage(&message).code());
- ASSERT_EQ("hi", message);
-
- manager.OnEvent("Page.javascriptDialogClosing", params);
- ASSERT_FALSE(manager.IsDialogOpen());
- ASSERT_EQ(kNoAlertOpen, manager.GetDialogMessage(&message).code());
- ASSERT_EQ(kNoAlertOpen, manager.HandleDialog(false, "").code());
-}
« no previous file with comments | « chrome/test/chromedriver/javascript_dialog_manager.cc ('k') | chrome/test/chromedriver/key_converter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698