Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 12207167: Cleanup: Remove deprecated base::Value methods from chrome/common. Use base::Value too. (Closed)

Created:
7 years, 10 months ago by Lei Zhang
Modified:
7 years, 10 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Cleanup: Remove deprecated base::Value methods from chrome/common. Use base::Value too. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182406

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+308 lines, -292 lines) Patch
M chrome/common/custom_handlers/protocol_handler.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/common/extensions/api/extension_api_unittest.cc View 5 chunks +16 lines, -16 lines 0 comments Download
M chrome/common/extensions/api/identity/extension_manifests_auth_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/common/extensions/extension_file_util_unittest.cc View 4 chunks +13 lines, -12 lines 0 comments Download
M chrome/common/extensions/extension_set_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/features/base_feature_provider_unittest.cc View 5 chunks +13 lines, -13 lines 0 comments Download
M chrome/common/extensions/features/simple_feature_unittest.cc View 10 chunks +32 lines, -32 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_storage_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/manifest_unittest.cc View 8 chunks +18 lines, -17 lines 0 comments Download
M chrome/common/extensions/permissions/api_permission_set_unittest.cc View 10 chunks +37 lines, -37 lines 0 comments Download
M chrome/common/extensions/permissions/socket_permission_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/value_builder.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M chrome/common/json_schema_validator_unittest_base.cc View 29 chunks +136 lines, -122 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Lei Zhang
7 years, 10 months ago (2013-02-13 23:04:04 UTC) #1
Yoyo Zhou
LGTM
7 years, 10 months ago (2013-02-13 23:17:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/12207167/1
7 years, 10 months ago (2013-02-14 00:59:35 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) aura_unittests, base_unittests, browser_tests, cacheinvalidation_unittests, check_deps, chromeos_unittests, ...
7 years, 10 months ago (2013-02-14 01:23:52 UTC) #4
Yoyo Zhou
On 2013/02/14 01:23:52, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 10 months ago (2013-02-14 02:41:50 UTC) #5
Lei Zhang
On 2013/02/14 02:41:50, Yoyo Zhou wrote: > I guess I was expecting to see chrome/common/extensions/manifest.cc ...
7 years, 10 months ago (2013-02-14 02:49:35 UTC) #6
Yoyo Zhou
On 2013/02/14 02:49:35, Lei Zhang wrote: > On 2013/02/14 02:41:50, Yoyo Zhou wrote: > > ...
7 years, 10 months ago (2013-02-14 02:50:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/12207167/1
7 years, 10 months ago (2013-02-14 05:35:37 UTC) #8
commit-bot: I haz the power
7 years, 10 months ago (2013-02-14 07:32:47 UTC) #9
Message was sent while issue was closed.
Change committed as 182406

Powered by Google App Engine
This is Rietveld 408576698