Cleanup: Remove deprecated base::Value methods from chrome/common. Use base::Value too.

chrome/common/extensions/extension_set_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_path.h"
 #include "base/logging.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/values.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/extension_set.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using extensions::Extension;
 
 namespace {
 
 scoped_refptr<Extension> CreateTestExtension(const std::string& name,
                                              const std::string& launch_url,
                                              const std::string& extent) {
 #if defined(OS_WIN)
   base::FilePath path(FILE_PATH_LITERAL("c:\\"));
 #else
   base::FilePath path(FILE_PATH_LITERAL("/"));
 #endif
   path = path.AppendASCII(name);
 
-  DictionaryValue manifest;
+  base::DictionaryValue manifest;
   manifest.SetString("name", name);
   manifest.SetString("version", "1");
 
   if (!launch_url.empty())
     manifest.SetString("app.launch.web_url", launch_url);
 
   if (!extent.empty()) {
-    ListValue* urls = new ListValue();
+    base::ListValue* urls = new base::ListValue();
     manifest.Set("app.urls", urls);
-    urls->Append(Value::CreateStringValue(extent));
+    urls->Append(new base::StringValue(extent));
   }
 
   std::string error;
   scoped_refptr<Extension> extension(
       Extension::Create(path, extensions::Manifest::INTERNAL, manifest,
                         Extension::NO_FLAGS, &error));
   EXPECT_TRUE(extension.get()) << error;
   return extension;
 }
 
-} // namespace
+}  // namespace
 
 TEST(ExtensionSetTest, ExtensionSet) {
   scoped_refptr<Extension> ext1(CreateTestExtension(
       "a", "https://chrome.google.com/launch", "https://chrome.google.com/"));
 
   scoped_refptr<Extension> ext2(CreateTestExtension(
       "a", "http://code.google.com/p/chromium",
       "http://code.google.com/p/chromium/"));
 
   scoped_refptr<Extension> ext3(CreateTestExtension(
@@ skipping 67 matching lines @@
   to_add->Insert(ext5);
   to_add->Insert(ext6);
 
   ASSERT_TRUE(extensions.Contains(ext3->id()));
   ASSERT_TRUE(extensions.InsertAll(*to_add));
   EXPECT_EQ(4u, extensions.size());
 
   ASSERT_FALSE(extensions.InsertAll(*to_add));  // Re-adding same set no-ops.
   EXPECT_EQ(4u, extensions.size());
 }