Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/common/extensions/permissions/api_permission_set_unittest.cc

Issue 12207167: Cleanup: Remove deprecated base::Value methods from chrome/common. Use base::Value too. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/manifest_unittest.cc ('k') | chrome/common/extensions/permissions/socket_permission_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/permissions/api_permission_set_unittest.cc
===================================================================
--- chrome/common/extensions/permissions/api_permission_set_unittest.cc (revision 182296)
+++ chrome/common/extensions/permissions/api_permission_set_unittest.cc (working copy)
@@ -47,10 +47,10 @@
PermissionsInfo::GetInstance()->GetByID(APIPermission::kSocket);
permission = permission_info->CreateAPIPermission();
{
- scoped_ptr<ListValue> value(new ListValue());
- value->Append(Value::CreateStringValue("tcp-connect:*.example.com:80"));
- value->Append(Value::CreateStringValue("udp-bind::8080"));
- value->Append(Value::CreateStringValue("udp-send-to::8888"));
+ scoped_ptr<base::ListValue> value(new base::ListValue());
+ value->Append(new base::StringValue("tcp-connect:*.example.com:80"));
+ value->Append(new base::StringValue("udp-bind::8080"));
+ value->Append(new base::StringValue("udp-send-to::8888"));
if (!permission->FromValue(value.get())) {
NOTREACHED();
}
@@ -83,9 +83,9 @@
permission = permission_info->CreateAPIPermission();
{
- scoped_ptr<ListValue> value(new ListValue());
- value->Append(Value::CreateStringValue("tcp-connect:*.example.com:80"));
- value->Append(Value::CreateStringValue("udp-send-to::8899"));
+ scoped_ptr<base::ListValue> value(new base::ListValue());
+ value->Append(new base::StringValue("tcp-connect:*.example.com:80"));
+ value->Append(new base::StringValue("udp-send-to::8899"));
if (!permission->FromValue(value.get())) {
NOTREACHED();
}
@@ -99,11 +99,11 @@
permission = permission_info->CreateAPIPermission();
{
- scoped_ptr<ListValue> value(new ListValue());
- value->Append(Value::CreateStringValue("tcp-connect:*.example.com:80"));
- value->Append(Value::CreateStringValue("udp-bind::8080"));
- value->Append(Value::CreateStringValue("udp-send-to::8888"));
- value->Append(Value::CreateStringValue("udp-send-to::8899"));
+ scoped_ptr<base::ListValue> value(new base::ListValue());
+ value->Append(new base::StringValue("tcp-connect:*.example.com:80"));
+ value->Append(new base::StringValue("udp-bind::8080"));
+ value->Append(new base::StringValue("udp-send-to::8888"));
+ value->Append(new base::StringValue("udp-send-to::8899"));
if (!permission->FromValue(value.get())) {
NOTREACHED();
}
@@ -139,10 +139,10 @@
apis1.insert(APIPermission::kBackground);
permission = permission_info->CreateAPIPermission();
{
- scoped_ptr<ListValue> value(new ListValue());
- value->Append(Value::CreateStringValue("tcp-connect:*.example.com:80"));
- value->Append(Value::CreateStringValue("udp-bind::8080"));
- value->Append(Value::CreateStringValue("udp-send-to::8888"));
+ scoped_ptr<base::ListValue> value(new base::ListValue());
+ value->Append(new base::StringValue("tcp-connect:*.example.com:80"));
+ value->Append(new base::StringValue("udp-bind::8080"));
+ value->Append(new base::StringValue("udp-send-to::8888"));
if (!permission->FromValue(value.get())) {
NOTREACHED();
}
@@ -167,10 +167,10 @@
apis2.insert(APIPermission::kPlugin);
permission = permission_info->CreateAPIPermission();
{
- scoped_ptr<ListValue> value(new ListValue());
- value->Append(Value::CreateStringValue("udp-bind::8080"));
- value->Append(Value::CreateStringValue("udp-send-to::8888"));
- value->Append(Value::CreateStringValue("udp-send-to::8899"));
+ scoped_ptr<base::ListValue> value(new base::ListValue());
+ value->Append(new base::StringValue("udp-bind::8080"));
+ value->Append(new base::StringValue("udp-send-to::8888"));
+ value->Append(new base::StringValue("udp-send-to::8899"));
if (!permission->FromValue(value.get())) {
NOTREACHED();
}
@@ -180,9 +180,9 @@
expected_apis.insert(APIPermission::kTab);
permission = permission_info->CreateAPIPermission();
{
- scoped_ptr<ListValue> value(new ListValue());
- value->Append(Value::CreateStringValue("udp-bind::8080"));
- value->Append(Value::CreateStringValue("udp-send-to::8888"));
+ scoped_ptr<base::ListValue> value(new base::ListValue());
+ value->Append(new base::StringValue("udp-bind::8080"));
+ value->Append(new base::StringValue("udp-send-to::8888"));
if (!permission->FromValue(value.get())) {
NOTREACHED();
}
@@ -217,10 +217,10 @@
apis1.insert(APIPermission::kBackground);
permission = permission_info->CreateAPIPermission();
{
- scoped_ptr<ListValue> value(new ListValue());
- value->Append(Value::CreateStringValue("tcp-connect:*.example.com:80"));
- value->Append(Value::CreateStringValue("udp-bind::8080"));
- value->Append(Value::CreateStringValue("udp-send-to::8888"));
+ scoped_ptr<base::ListValue> value(new base::ListValue());
+ value->Append(new base::StringValue("tcp-connect:*.example.com:80"));
+ value->Append(new base::StringValue("udp-bind::8080"));
+ value->Append(new base::StringValue("udp-send-to::8888"));
if (!permission->FromValue(value.get())) {
NOTREACHED();
}
@@ -238,9 +238,9 @@
apis2.insert(APIPermission::kPlugin);
permission = permission_info->CreateAPIPermission();
{
- scoped_ptr<ListValue> value(new ListValue());
- value->Append(Value::CreateStringValue("tcp-connect:*.example.com:80"));
- value->Append(Value::CreateStringValue("udp-send-to::8899"));
+ scoped_ptr<base::ListValue> value(new base::ListValue());
+ value->Append(new base::StringValue("tcp-connect:*.example.com:80"));
+ value->Append(new base::StringValue("udp-send-to::8899"));
if (!permission->FromValue(value.get())) {
NOTREACHED();
}
@@ -250,9 +250,9 @@
expected_apis.insert(APIPermission::kBackground);
permission = permission_info->CreateAPIPermission();
{
- scoped_ptr<ListValue> value(new ListValue());
- value->Append(Value::CreateStringValue("udp-bind::8080"));
- value->Append(Value::CreateStringValue("udp-send-to::8888"));
+ scoped_ptr<base::ListValue> value(new base::ListValue());
+ value->Append(new base::StringValue("udp-bind::8080"));
+ value->Append(new base::StringValue("udp-send-to::8888"));
if (!permission->FromValue(value.get())) {
NOTREACHED();
}
@@ -285,10 +285,10 @@
apis.insert(APIPermission::kBackground);
permission = permission_info->CreateAPIPermission();
{
- scoped_ptr<ListValue> value(new ListValue());
- value->Append(Value::CreateStringValue("tcp-connect:*.example.com:80"));
- value->Append(Value::CreateStringValue("udp-bind::8080"));
- value->Append(Value::CreateStringValue("udp-send-to::8888"));
+ scoped_ptr<base::ListValue> value(new base::ListValue());
+ value->Append(new base::StringValue("tcp-connect:*.example.com:80"));
+ value->Append(new base::StringValue("udp-bind::8080"));
+ value->Append(new base::StringValue("udp-send-to::8888"));
if (!permission->FromValue(value.get())) {
NOTREACHED();
}
« no previous file with comments | « chrome/common/extensions/manifest_unittest.cc ('k') | chrome/common/extensions/permissions/socket_permission_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698