chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc - Issue 12207167: Cleanup: Remove deprecated base::Value methods from chrome/common. Use base::Value too.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc

Issue 12207167: Cleanup: Remove deprecated base::Value methods from chrome/common. Use base::Value too. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/features/simple_feature_unittest.cc ('k') | chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc

===================================================================

--- chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc (revision 182296)

+++ chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc (working copy)

@@ -27,7 +27,7 @@

TEST_F(ExtensionManifestTest, BackgroundScripts) {

std::string error;

- scoped_ptr<DictionaryValue> manifest(

+ scoped_ptr<base::DictionaryValue> manifest(

LoadManifest("background_scripts.json", &error));

ASSERT_TRUE(manifest.get());

@@ -56,7 +56,7 @@

EXPECT_TRUE(extension->allow_background_js_access());

std::string error;

- scoped_ptr<DictionaryValue> manifest(

+ scoped_ptr<base::DictionaryValue> manifest(

LoadManifest("background_page_legacy.json", &error));

ASSERT_TRUE(manifest.get());

extension = LoadAndExpectSuccess(Manifest(manifest.get(), ""));

@@ -87,7 +87,7 @@

chrome::VersionInfo::CHANNEL_DEV);

std::string error;

- scoped_ptr<DictionaryValue> manifest(

+ scoped_ptr<base::DictionaryValue> manifest(

LoadManifest("background_page.json", &error));

ASSERT_TRUE(manifest.get());

manifest->SetBoolean(keys::kBackgroundPersistent, false);

@@ -97,8 +97,8 @@

ASSERT_TRUE(extension);

EXPECT_TRUE(extension->has_lazy_background_page());

- ListValue* permissions = new ListValue();

- permissions->Append(Value::CreateStringValue("webRequest"));

+ base::ListValue* permissions = new base::ListValue();

+ permissions->Append(new base::StringValue("webRequest"));

manifest->Set(keys::kPermissions, permissions);

LoadAndExpectError(Manifest(manifest.get(), ""),

errors::kWebRequestConflictsWithLazyBackground);