Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: chrome/common/extensions/api/identity/extension_manifests_auth_unittest.cc

Issue 12207167: Cleanup: Remove deprecated base::Value methods from chrome/common. Use base::Value too. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/identity/extension_manifests_auth_unittest.cc
===================================================================
--- chrome/common/extensions/api/identity/extension_manifests_auth_unittest.cc (revision 182296)
+++ chrome/common/extensions/api/identity/extension_manifests_auth_unittest.cc (working copy)
@@ -21,20 +21,20 @@
};
TEST_F(OAuth2ManifestTest, OAuth2SectionParsing) {
- DictionaryValue base_manifest;
+ base::DictionaryValue base_manifest;
base_manifest.SetString(keys::kName, "test");
base_manifest.SetString(keys::kVersion, "0.1");
base_manifest.SetInteger(keys::kManifestVersion, 2);
base_manifest.SetString(keys::kOAuth2ClientId, "client1");
- ListValue* scopes = new ListValue();
- scopes->Append(Value::CreateStringValue("scope1"));
- scopes->Append(Value::CreateStringValue("scope2"));
+ base::ListValue* scopes = new base::ListValue();
+ scopes->Append(new base::StringValue("scope1"));
+ scopes->Append(new base::StringValue("scope2"));
base_manifest.Set(keys::kOAuth2Scopes, scopes);
// OAuth2 section should be parsed for an extension.
{
- DictionaryValue ext_manifest;
+ base::DictionaryValue ext_manifest;
// Lack of "app" section representa an extension. So the base manifest
// itself represents an extension.
ext_manifest.MergeDictionary(&base_manifest);
@@ -51,7 +51,7 @@
// OAuth2 section should be parsed for a packaged app.
{
- DictionaryValue app_manifest;
+ base::DictionaryValue app_manifest;
app_manifest.SetString(keys::kLaunchLocalPath, "launch.html");
app_manifest.MergeDictionary(&base_manifest);
@@ -67,7 +67,7 @@
// OAuth2 section should NOT be parsed for a hosted app.
{
- DictionaryValue app_manifest;
+ base::DictionaryValue app_manifest;
app_manifest.SetString(keys::kLaunchWebURL, "http://www.google.com");
app_manifest.MergeDictionary(&base_manifest);
« no previous file with comments | « chrome/common/extensions/api/extension_api_unittest.cc ('k') | chrome/common/extensions/extension_file_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698