chrome/common/extensions/manifest_tests/extension_manifests_storage_unittest.cc - Issue 12207167: Cleanup: Remove deprecated base::Value methods from chrome/common. Use base::Value too.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_storage_unittest.cc

Issue 12207167: Cleanup: Remove deprecated base::Value methods from chrome/common. Use base::Value too. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc ('k') | chrome/common/extensions/manifest_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_storage_unittest.cc

===================================================================

--- chrome/common/extensions/manifest_tests/extension_manifests_storage_unittest.cc (revision 182296)

+++ chrome/common/extensions/manifest_tests/extension_manifests_storage_unittest.cc (working copy)

@@ -10,12 +10,12 @@

namespace keys = extension_manifest_keys;

TEST_F(ExtensionManifestTest, StorageAPIManifestVersionAvailability) {

- DictionaryValue base_manifest;

+ base::DictionaryValue base_manifest;

{

base_manifest.SetString(keys::kName, "test");

base_manifest.SetString(keys::kVersion, "0.1");

- ListValue* permissions = new ListValue();

- permissions->Append(Value::CreateStringValue("storage"));

+ base::ListValue* permissions = new base::ListValue();

+ permissions->Append(new base::StringValue("storage"));

base_manifest.Set(keys::kPermissions, permissions);

}

@@ -30,7 +30,7 @@

// Extension with manifest version 1 cannot use storage API.

{

- DictionaryValue manifest_with_version;

+ base::DictionaryValue manifest_with_version;

manifest_with_version.SetInteger(keys::kManifestVersion, 1);

manifest_with_version.MergeDictionary(&base_manifest);

@@ -40,7 +40,7 @@

// Extension with manifest version 2 *can* use storage API.

{

- DictionaryValue manifest_with_version;

+ base::DictionaryValue manifest_with_version;

manifest_with_version.SetInteger(keys::kManifestVersion, 2);

manifest_with_version.MergeDictionary(&base_manifest);