Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11777009: Remove redundant |errored| member from IconHostMsg_DidDownloadFavicon (Closed)

Created:
7 years, 11 months ago by pkotwicz
Modified:
7 years, 11 months ago
Reviewers:
jam, Cait (Slow), sky
CC:
chromium-reviews, jam, sadrul, ben+watch_chromium.org, tfarina, jeremya+watch_chromium.org, browser-components-watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Remove redundant |errored| member from IconHostMsg_DidDownloadFavicon Bug=None Test=None R=caitkp, sky TBR=jam Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176028

Patch Set 1 #

Patch Set 2 : Fix FaviconHandlerTest.* #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -59 lines) Patch
M chrome/browser/favicon/favicon_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/favicon/favicon_handler.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/favicon/favicon_handler_unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/favicon/favicon_tab_helper.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/favicon/favicon_tab_helper.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc View 3 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/extensions/shell_window.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/extensions/shell_window.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/metro_pin_tab_helper_win.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/metro_pin_tab_helper_win.cc View 1 2 4 chunks +21 lines, -27 lines 0 comments Download
M chrome/browser/ui/views/ash/balloon_view_ash.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/create_application_shortcut_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/create_application_shortcut_view.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/web_applications/web_app_ui.cc View 3 chunks +1 line, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M content/common/icon_messages.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/public/browser/web_contents.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/favicon_helper.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
pkotwicz
Cait, can you please take a look? Sorry for not writing this CL earlier.
7 years, 11 months ago (2013-01-06 19:53:09 UTC) #1
Cait (Slow)
LGTM (but as I am not an official Chromium committer yet, you'll probably need someone ...
7 years, 11 months ago (2013-01-08 15:27:12 UTC) #2
pkotwicz
sky for OWNERS
7 years, 11 months ago (2013-01-09 00:11:17 UTC) #3
sky
LGTM
7 years, 11 months ago (2013-01-09 00:50:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/11777009/1
7 years, 11 months ago (2013-01-09 23:55:01 UTC) #5
commit-bot: I haz the power
Presubmit check for 11777009-1 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 11 months ago (2013-01-09 23:55:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/11777009/1
7 years, 11 months ago (2013-01-10 00:15:29 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 11 months ago (2013-01-10 00:55:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/11777009/9003
7 years, 11 months ago (2013-01-10 01:12:57 UTC) #9
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 11 months ago (2013-01-10 02:18:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/11777009/16005
7 years, 11 months ago (2013-01-10 02:52:08 UTC) #11
commit-bot: I haz the power
7 years, 11 months ago (2013-01-10 05:48:55 UTC) #12
Message was sent while issue was closed. 
Change committed as 176028

Powered by Google App Engine
This is Rietveld 408576698