Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: content/browser/web_contents/web_contents_impl.h

Issue 11777009: Remove redundant |errored| member from IconHostMsg_DidDownloadFavicon (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 552 matching lines...) Expand 10 before | Expand all | Expand 10 after
563 const std::string& name, 563 const std::string& name,
564 const base::ListValue& args); 564 const base::ListValue& args);
565 void OnRequestPpapiBrokerPermission(int request_id, 565 void OnRequestPpapiBrokerPermission(int request_id,
566 const GURL& url, 566 const GURL& url,
567 const FilePath& plugin_path); 567 const FilePath& plugin_path);
568 void OnBrowserPluginCreateGuest( 568 void OnBrowserPluginCreateGuest(
569 int instance_id, 569 int instance_id,
570 const BrowserPluginHostMsg_CreateGuest_Params& params); 570 const BrowserPluginHostMsg_CreateGuest_Params& params);
571 void OnDidDownloadFavicon(int id, 571 void OnDidDownloadFavicon(int id,
572 const GURL& image_url, 572 const GURL& image_url,
573 bool errored,
574 int requested_size, 573 int requested_size,
575 const std::vector<SkBitmap>& bitmaps); 574 const std::vector<SkBitmap>& bitmaps);
576 void OnUpdateFaviconURL(int32 page_id, 575 void OnUpdateFaviconURL(int32 page_id,
577 const std::vector<FaviconURL>& candidates); 576 const std::vector<FaviconURL>& candidates);
578 577
579 // Changes the IsLoading state and notifies delegate as needed 578 // Changes the IsLoading state and notifies delegate as needed
580 // |details| is used to provide details on the load that just finished 579 // |details| is used to provide details on the load that just finished
581 // (but can be null if not applicable). Can be overridden. 580 // (but can be null if not applicable). Can be overridden.
582 void SetIsLoading(bool is_loading, 581 void SetIsLoading(bool is_loading,
583 LoadNotificationDetails* details); 582 LoadNotificationDetails* details);
(...skipping 281 matching lines...) Expand 10 before | Expand all | Expand 10 after
865 // Maps the ids of pending favicon downloads to their callbacks 864 // Maps the ids of pending favicon downloads to their callbacks
866 typedef std::map<int, FaviconDownloadCallback> FaviconDownloadMap; 865 typedef std::map<int, FaviconDownloadCallback> FaviconDownloadMap;
867 FaviconDownloadMap favicon_download_map_; 866 FaviconDownloadMap favicon_download_map_;
868 867
869 DISALLOW_COPY_AND_ASSIGN(WebContentsImpl); 868 DISALLOW_COPY_AND_ASSIGN(WebContentsImpl);
870 }; 869 };
871 870
872 } // namespace content 871 } // namespace content
873 872
874 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 873 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/web_applications/web_app_ui.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698