chrome/browser/favicon/favicon_tab_helper.cc - Issue 11777009: Remove redundant |errored| member from IconHostMsg_DidDownloadFavicon

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/favicon/favicon_tab_helper.cc

Issue 11777009: Remove redundant |errored| member from IconHostMsg_DidDownloadFavicon (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/favicon/favicon_tab_helper.cc

diff --git a/chrome/browser/favicon/favicon_tab_helper.cc b/chrome/browser/favicon/favicon_tab_helper.cc

index 223707d60e605d3a13e795b30b8088e8496460c1..6b551574c999288d7f136e1007cffc2db5591248 100644

--- a/chrome/browser/favicon/favicon_tab_helper.cc

+++ b/chrome/browser/favicon/favicon_tab_helper.cc

@@ -166,13 +166,12 @@ void FaviconTabHelper::DidUpdateFaviconURL(

void FaviconTabHelper::DidDownloadFavicon(

int id,

const GURL& image_url,

- bool errored,

int requested_size,

const std::vector<SkBitmap>& bitmaps) {

favicon_handler_->OnDidDownloadFavicon(

- id, image_url, errored, requested_size, bitmaps);

+ id, image_url, requested_size, bitmaps);

if (touch_icon_handler_.get()) {

touch_icon_handler_->OnDidDownloadFavicon(

- id, image_url, errored, requested_size, bitmaps);

+ id, image_url, requested_size, bitmaps);

}