Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Side by Side Diff: chrome/browser/favicon/favicon_tab_helper.h

Issue 11777009: Remove redundant |errored| member from IconHostMsg_DidDownloadFavicon (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_FAVICON_FAVICON_TAB_HELPER_H_ 5 #ifndef CHROME_BROWSER_FAVICON_FAVICON_TAB_HELPER_H_
6 #define CHROME_BROWSER_FAVICON_FAVICON_TAB_HELPER_H_ 6 #define CHROME_BROWSER_FAVICON_FAVICON_TAB_HELPER_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 const GURL& url, 75 const GURL& url,
76 content::NavigationController::ReloadType reload_type) OVERRIDE; 76 content::NavigationController::ReloadType reload_type) OVERRIDE;
77 virtual void DidNavigateMainFrame( 77 virtual void DidNavigateMainFrame(
78 const content::LoadCommittedDetails& details, 78 const content::LoadCommittedDetails& details,
79 const content::FrameNavigateParams& params) OVERRIDE; 79 const content::FrameNavigateParams& params) OVERRIDE;
80 80
81 // Favicon download callback. 81 // Favicon download callback.
82 void DidDownloadFavicon( 82 void DidDownloadFavicon(
83 int id, 83 int id,
84 const GURL& image_url, 84 const GURL& image_url,
85 bool errored,
86 int requested_size, 85 int requested_size,
87 const std::vector<SkBitmap>& bitmaps); 86 const std::vector<SkBitmap>& bitmaps);
88 87
89 Profile* profile_; 88 Profile* profile_;
90 89
91 scoped_ptr<FaviconHandler> favicon_handler_; 90 scoped_ptr<FaviconHandler> favicon_handler_;
92 91
93 // Handles downloading touchicons. It is NULL if 92 // Handles downloading touchicons. It is NULL if
94 // browser_defaults::kEnableTouchIcon is false. 93 // browser_defaults::kEnableTouchIcon is false.
95 scoped_ptr<FaviconHandler> touch_icon_handler_; 94 scoped_ptr<FaviconHandler> touch_icon_handler_;
96 95
97 DISALLOW_COPY_AND_ASSIGN(FaviconTabHelper); 96 DISALLOW_COPY_AND_ASSIGN(FaviconTabHelper);
98 }; 97 };
99 98
100 #endif // CHROME_BROWSER_FAVICON_FAVICON_TAB_HELPER_H_ 99 #endif // CHROME_BROWSER_FAVICON_FAVICON_TAB_HELPER_H_
OLDNEW
« no previous file with comments | « chrome/browser/favicon/favicon_handler_unittest.cc ('k') | chrome/browser/favicon/favicon_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698