Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5320)

Unified Diff: chrome/browser/favicon/favicon_handler_unittest.cc

Issue 11777009: Remove redundant |errored| member from IconHostMsg_DidDownloadFavicon (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/favicon/favicon_handler.cc ('k') | chrome/browser/favicon/favicon_tab_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/favicon/favicon_handler_unittest.cc
diff --git a/chrome/browser/favicon/favicon_handler_unittest.cc b/chrome/browser/favicon/favicon_handler_unittest.cc
index 8233e96c1b80374d816ca9b485fd7e2dda997dfa..3f824a7ce8d8b6903c5c5f44fa75ca989d3a64ef 100644
--- a/chrome/browser/favicon/favicon_handler_unittest.cc
+++ b/chrome/browser/favicon/favicon_handler_unittest.cc
@@ -336,10 +336,10 @@ void DownloadHandler::InvokeCallback() {
download_->image_size : gfx::kFaviconSize;
FillDataToBitmap(downloaded_size, downloaded_size, &bitmap);
std::vector<SkBitmap> bitmaps;
- bitmaps.push_back(bitmap);
+ if (!failed_)
+ bitmaps.push_back(bitmap);
favicon_helper_->OnDidDownloadFavicon(
- download_->download_id, download_->image_url, failed_,
- kRequestedSize, bitmaps);
+ download_->download_id, download_->image_url, kRequestedSize, bitmaps);
}
class FaviconHandlerTest : public ChromeRenderViewHostTestHarness {
« no previous file with comments | « chrome/browser/favicon/favicon_handler.cc ('k') | chrome/browser/favicon/favicon_tab_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698