chrome/browser/ui/views/create_application_shortcut_view.cc - Issue 11777009: Remove redundant |errored| member from IconHostMsg_DidDownloadFavicon

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/create_application_shortcut_view.cc

Issue 11777009: Remove redundant |errored| member from IconHostMsg_DidDownloadFavicon (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/create_application_shortcut_view.cc

diff --git a/chrome/browser/ui/views/create_application_shortcut_view.cc b/chrome/browser/ui/views/create_application_shortcut_view.cc

index 4b92f828fd4d186cb4d4ecb2ec8dc5bc020c1d8d..f5e3b08b0b1ff948dcb56086145173467be06261 100644

--- a/chrome/browser/ui/views/create_application_shortcut_view.cc

+++ b/chrome/browser/ui/views/create_application_shortcut_view.cc

@@ -452,7 +452,6 @@ void CreateUrlApplicationShortcutView::FetchIcon() {

void CreateUrlApplicationShortcutView::DidDownloadFavicon(

int id,

const GURL& image_url,

- bool errored,

int requested_size,

const std::vector<SkBitmap>& bitmaps) {

if (id != pending_download_id_)

@@ -473,7 +472,7 @@ void CreateUrlApplicationShortcutView::DidDownloadFavicon(

image = bitmaps[closest_index];

}

- if (!errored && !image.isNull()) {

+ if (!image.isNull()) {

shortcut_info_.favicon = gfx::Image(image);

static_cast<AppInfoView*>(app_info_)->UpdateIcon(shortcut_info_.favicon);

} else {