Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11636051: Rename ActiveAnimation -> Animation (Closed)

Created:
8 years ago by Ian Vollick
Modified:
7 years, 11 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Rename ActiveAnimation -> Animation ActiveAnimation has a bad name. It used to be the case that 'active' animations were a subset of all animations, but now every animation in cc/ is 'active' and I think that's confusing. R=enne@chromium.org BUG=None NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174267 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175344

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+407 lines, -777 lines) Patch
D cc/active_animation.h View 1 chunk +0 lines, -162 lines 0 comments Download
D cc/active_animation.cc View 1 chunk +0 lines, -208 lines 0 comments Download
D cc/active_animation_unittest.cc View 1 chunk +0 lines, -218 lines 0 comments Download
A + cc/animation.h View 5 chunks +13 lines, -13 lines 0 comments Download
A + cc/animation.cc View 10 chunks +19 lines, -19 lines 0 comments Download
M cc/animation_events.h View 2 chunks +3 lines, -3 lines 0 comments Download
A cc/animation_unittest.cc View 1 chunk +218 lines, -0 lines 0 comments Download
M cc/cc.gyp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/cc_tests.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/layer.h View 2 chunks +2 lines, -2 lines 0 comments Download
cc/layer.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M cc/layer_animation_controller.h View 4 chunks +6 lines, -6 lines 0 comments Download
M cc/layer_animation_controller.cc View 1 22 chunks +40 lines, -40 lines 0 comments Download
M cc/layer_animation_controller_unittest.cc View 26 chunks +67 lines, -67 lines 0 comments Download
cc/layer_impl.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layer_tree_host_unittest_animation.cc View 1 6 chunks +13 lines, -13 lines 0 comments Download
M cc/layer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/animation_test_common.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/animation_test_common.cc View 3 chunks +3 lines, -3 lines 0 comments Download
cc/test/layer_tree_test_common.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/compositor_bindings/web_animation_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/compositor_bindings/web_animation_impl.cc View 4 chunks +5 lines, -5 lines 0 comments Download
webkit/compositor_bindings/web_layer_impl.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
enne (OOO)
lgtm
8 years ago (2012-12-20 19:38:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/11636051/1
8 years ago (2012-12-20 19:51:10 UTC) #2
commit-bot: I haz the power
Change committed as 174267
8 years ago (2012-12-20 23:07:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/11636051/13001
7 years, 11 months ago (2013-01-07 16:20:31 UTC) #4
commit-bot: I haz the power
7 years, 11 months ago (2013-01-07 16:21:21 UTC) #5
Message was sent while issue was closed. 
Change committed as 175344

Powered by Google App Engine
This is Rietveld 408576698