Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 11412044: cc: Remove opaque flags from SharedQuadState and DrawQuad (Closed)

Created:
8 years, 1 month ago by danakj
Modified:
8 years, 1 month ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, feature-media-reviews_chromium.org, cc-bugs_chromium.org, piman, backer
Visibility:
Public.

Description

cc: Remove opaque flags from SharedQuadState and DrawQuad Now we will use the opaqueRect (already present on DrawQuad) to tell when things are opaque or not. Each Quad constructor that can be opaque take an opaqueRect. Generally, callers set it equal to the quadRect when contentsOpaque(). TiledLayerImpl can set it to a smaller rect sometimes since it has more knowledge. This made the scrollbar code a bit nicer for the thumb so that it doesn't need to set needs_blending anymore, as the thumb can be marked non-opaque. DebugBorderQuad sets an empty opaqueRect now, so it doesn't need to set needs_blending. Covered by existing tests. BUG=152337 R=enne Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168387

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -102 lines) Patch
M cc/checkerboard_draw_quad.cc View 1 chunk +3 lines, -1 line 0 comments Download
M cc/debug_border_draw_quad.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/delegated_renderer_layer_impl_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/draw_quad.h View 2 chunks +4 lines, -5 lines 0 comments Download
M cc/draw_quad.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M cc/draw_quad_unittest.cc View 7 chunks +14 lines, -9 lines 0 comments Download
M cc/heads_up_display_layer_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/io_surface_draw_quad.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/io_surface_draw_quad.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M cc/io_surface_layer_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layer_tree_host_impl_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/nine_patch_layer_impl.cc View 1 chunk +12 lines, -8 lines 0 comments Download
M cc/render_pass.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/render_pass_draw_quad.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/render_pass_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/render_surface_impl.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M cc/render_surface_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/scrollbar_layer_impl.cc View 2 chunks +13 lines, -6 lines 0 comments Download
M cc/shared_quad_state.h View 1 chunk +2 lines, -3 lines 0 comments Download
M cc/shared_quad_state.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M cc/software_renderer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/solid_color_draw_quad.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M cc/stream_video_draw_quad.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/stream_video_draw_quad.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M cc/test/render_pass_test_common.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M cc/texture_draw_quad.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/texture_draw_quad.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M cc/texture_layer_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/tile_draw_quad.cc View 2 chunks +1 line, -2 lines 0 comments Download
M cc/tiled_layer_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/video_layer_impl.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M cc/yuv_video_draw_quad.h View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/yuv_video_draw_quad.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
danakj
8 years, 1 month ago (2012-11-16 19:18:04 UTC) #1
enne (OOO)
lgtm
8 years, 1 month ago (2012-11-16 20:31:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/11412044/1
8 years, 1 month ago (2012-11-16 22:16:50 UTC) #3
commit-bot: I haz the power
8 years, 1 month ago (2012-11-17 06:10:08 UTC) #4
Change committed as 168387

Powered by Google App Engine
This is Rietveld 408576698